Don't exit successfully if sourcing the debconf module fails

* Abort the config script rather than exiting successfully if the
  debconf shell module is not available.  The config script should never
  be run in the absence of debconf, so if this fails, something deeper
  is wrong and we shouldn't blindly continue.

diff --git a/debian/changelog b/debian/changelog
index eb6869aeadb30f8d32eb40ba4a3ec091655ec88e..8b17f710db419d9b9e2e75f1123942c1b1577870 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -44,6 +44,10 @@ openafs (1.4.8.dfsg1-1) UNRELEASED; urgency=low
       default command stacks in dh.
     - Use a debian/clean configuration file to let dh clean do more of the
       work rather than using rm commands in debian/rules.
+  * Abort the config script rather than exiting successfully if the
+    debconf shell module is not available.  The config script should never
+    be run in the absence of debconf, so if this fails, something deeper
+    is wrong and we shouldn't blindly continue.
   * Add ${misc:Depends} to all dependencies.
   * Add explanations for the Lintian overrides.
   * Use set -e instead of #!/bin/sh -e in maintainer scripts.

diff --git a/debian/openafs-client.config b/debian/openafs-client.config
index 8c100163aa244721533744060362286a6da712d9..759bbb2f08cbe234c9bedf5b3f999ae2c2ac15da 100644 (file)
--- a/debian/openafs-client.config
+++ b/debian/openafs-client.config
@@ -1,7 +1,7 @@
 #!/bin/sh
 set -e
 
-. /usr/share/debconf/confmodule || exit
+. /usr/share/debconf/confmodule
 
 db_version 2.0
 if [ -r /etc/openafs/ThisCell ] ; then

diff --git a/debian/openafs-fileserver.config b/debian/openafs-fileserver.config
index ed7300727ddd52311d6dc754c8e26fd88b6f2571..04e3260088ade71c40673d849a6d9d72abfb313e 100644 (file)
--- a/debian/openafs-fileserver.config
+++ b/debian/openafs-fileserver.config
@@ -1,7 +1,7 @@
 #!/bin/sh
 set -e
 
-. /usr/share/debconf/confmodule || exit
+. /usr/share/debconf/confmodule
 
 db_version 2.0