Tidy up libacl

Very small amount of prototyping
Rewrite comment block so it wraps at 80 lines
Make sure there are no implicit ints

Reviewed-on: http://gerrit.openafs.org/18
Reviewed-by: Russ Allbery <rra@stanford.edu>
Verified-by: Russ Allbery <rra@stanford.edu>

diff --git a/src/libacl/acl.h b/src/libacl/acl.h
index 71aa1fe3a31b8657da86d6503d63a6e359e3195b..d3af5a8d17da4669f7fd216f33529fd10454b77e 100644 (file)
--- a/src/libacl/acl.h
+++ b/src/libacl/acl.h
@@ -48,17 +48,19 @@ Used in VICE. This is how acccess lists are stored on secondary storage.
 #define ACL_MAXENTRIES 20
 
 /*
-External access lists are just char *'s, with the following format:  Begins with a decimal integer in format "%d\n%d\n"
-specifying the number of positive entries and negative entries that follow.  This is followed by the list
-of entries.  Each entry consists of a
-username or groupname followed by a decimal number representing the rights mask for that name.  Each
-entry in the list looks as if it had been produced by printf() using a format list of "%s\t%d\n".
-
-Note that the number of entries must be less than or equal to ACL_MAXENTRIES
-*/
+ * External access lists are just char *'s, with the following format:
+ *
+ * Begins with a decimal integer in format "%d\n%d\n" specifying the
+ * number of positive entries and negative entries that follow.  This is
+ * followed by the list of entries.  Each entry consists of a username or
+ * groupname followed by a decimal number representing the rights mask for
+ * that name.  Each entry in the list looks as if it had been produced by
+ * printf() using a format list of "%s\t%d\n".
+ *
+ * Note that the number of entries must be less than or equal to ACL_MAXENTRIES
+ */
 
-/* This is temporary hack to get around changing the volume package
-for now */
+/* This is temporary hack to get around changing the volume package for now */
 
 typedef struct acl_accessList AL_AccessList;
 
@@ -74,4 +76,7 @@ extern int acl_CheckRights(struct acl_accessList *acl, prlist *groups, int *righ
 extern int acl_IsAMember(afs_int32 aid, prlist *cps);
 #endif
 
+extern int acl_HtonACL(struct acl_accessList *);
+extern int acl_NtohACL(struct acl_accessList *);
+
 #endif

diff --git a/src/libacl/aclprocs.c b/src/libacl/aclprocs.c
index 3a8c4db3c95bb37cf0e004bf3dce72f5d1c6775e..d4041af652b2344ac960edb6db534551bb0d8ea0 100644 (file)
--- a/src/libacl/aclprocs.c
+++ b/src/libacl/aclprocs.c
@@ -180,7 +180,7 @@ acl_Externalize(struct acl_accessList *acl, char **elist)
 
     register int i;
     register int j;
-    register code;
+    register int code;
     register char *nextc;
     idlist lids;
     namelist lnames;