Eliminate some "implicit function declaration" warnings

Include appropriate header files to eliminate some warnings for
implicit function declarations.  These are simple cases that don't
generate new warnings because of the prototypes.
Use grp.h if it exists to get setgroups() definition.

Reviewed-on: http://gerrit.openafs.org/233
Tested-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Reviewed-by: Simon Wilkinson <sxw@inf.ed.ac.uk>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

diff --git a/acinclude.m4 b/acinclude.m4
index 0ec466ffda4048fa26b8e92ac7935c63f8126b52..15ecd8b60b9c6d3f4c9ddcc8c155dac589e6bd31 100644 (file)
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -1546,7 +1546,7 @@ dnl checks for header files.
 AC_HEADER_STDC
 AC_HEADER_SYS_WAIT
 AC_HEADER_DIRENT
-AC_CHECK_HEADERS(stdlib.h string.h unistd.h poll.h fcntl.h sys/time.h sys/file.h)
+AC_CHECK_HEADERS(stdlib.h string.h unistd.h poll.h fcntl.h sys/time.h sys/file.h grp.h)
 AC_CHECK_HEADERS(netinet/in.h netdb.h sys/fcntl.h sys/mnttab.h sys/mntent.h)
 AC_CHECK_HEADERS(mntent.h sys/vfs.h sys/param.h sys/fs_types.h sys/fstyp.h)
 AC_CHECK_HEADERS(sys/mount.h strings.h termios.h signal.h poll.h sys/pag.h)

diff --git a/src/budb/struct_ops.c b/src/budb/struct_ops.c
index 9a5c4ffabb091260ff865fa6207549ef1dd81aae..0894614792cdf8bfdfddbdbc2fdd15355b1803b3 100644 (file)
--- a/src/budb/struct_ops.c
+++ b/src/budb/struct_ops.c
@@ -21,6 +21,7 @@
 #include <sys/types.h>
 #include <afs/stds.h>
 #include <afs/bubasics.h>
+#include <afs/afsutil.h>
 #include <rx/xdr.h>
 #include <rx/rx.h>
 #include <string.h>

diff --git a/src/kauth/kkids.c b/src/kauth/kkids.c
index 6c5f1408e7d5255a68452825e5e2ff18221101ee..295ebbd03915cfee73620e74cd7cc5fce3070f67 100644 (file)
--- a/src/kauth/kkids.c
+++ b/src/kauth/kkids.c
@@ -34,6 +34,7 @@
 #include <afs/prs_fs.h>
 #include <stdlib.h>
 #include <string.h>
+#include <afs/sys_prototypes.h>
 
 #include "kkids.h"
 

diff --git a/src/kauth/knfs.c b/src/kauth/knfs.c
index b87740c538d96ccfc83fa9fbbc7ead458de12838..e48c1f0fc22677a1b69dcc4a5f21a09e90801e27 100644 (file)
--- a/src/kauth/knfs.c
+++ b/src/kauth/knfs.c
@@ -30,6 +30,7 @@
 #include <afs/cmd.h>
 #include <afs/auth.h>
 #include <afs/afsutil.h>
+#include <afs/sys_prototypes.h>
 
 /*
 Modifications:

diff --git a/src/kauth/user.c b/src/kauth/user.c
index 7245966d766680204a1f4312db7d339ca5dbb46f..ec82f62bbdf1fbe0d19f63e2b851cf11ef66340a 100644 (file)
--- a/src/kauth/user.c
+++ b/src/kauth/user.c
@@ -52,6 +52,7 @@
 #include <afs/ptuser.h>
 #include <afs/ptserver.h>
 #include <afs/afsutil.h>
+#include <afs/sys_prototypes.h>
 #include <rx/rx.h>
 #include <rx/rx_globals.h>
 #include <rx/rxkad.h>          /* max ticket lifetime */

diff --git a/src/libadmin/client/afs_clientAdmin.c b/src/libadmin/client/afs_clientAdmin.c
index 38e864d0e16c8181bfec3f033b7f65aafb1f6ac4..55f4e77f41f71a3edb65bf65a257b9010c67ead2 100644 (file)
--- a/src/libadmin/client/afs_clientAdmin.c
+++ b/src/libadmin/client/afs_clientAdmin.c
@@ -46,6 +46,7 @@
 #include <afs/ptserver.h>
 #include <afs/vlserver.h>
 #include <afs/pthread_glock.h>
+#include <afs/sys_prototypes.h>
 
 /*
  * AFS client administration functions.

diff --git a/src/sys/pioctl.c b/src/sys/pioctl.c
index b1d64e5f96a424aaeb13b2940b945461413632e3..b65210bb06c997a9c6ef2170b85c9ae5b51a7608 100644 (file)
--- a/src/sys/pioctl.c
+++ b/src/sys/pioctl.c
@@ -24,7 +24,11 @@
 #else
 #include <stdio.h>
 #endif
+#if defined(HAVE_UNISTD_H)
+#include <unistd.h>
+#endif
 #include "afssyscalls.h"
+#include "sys_prototypes.h"
 
 #ifdef AFS_AIX32_ENV
 /*

diff --git a/src/sys/rmtsysc.c b/src/sys/rmtsysc.c
index aa534ab92e91add7dc2cd1758ccd110e7b314f36..f92fe69597758eca699a6467782e18cf041ded47 100644 (file)
--- a/src/sys/rmtsysc.c
+++ b/src/sys/rmtsysc.c
@@ -34,6 +34,9 @@
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #endif
+#ifdef HAVE_GRP_H
+#include <grp.h>
+#endif
 #include <rx/xdr.h>
 #include "rmtsys.h"
 #include "sys_prototypes.h"

diff --git a/src/sys/setpag.c b/src/sys/setpag.c
index e1d4f4fc146dcad2822bd1bcda75091290c4a1e0..3d634f12985bccec17ad366abcdf5c5ed47c6fc4 100644 (file)
--- a/src/sys/setpag.c
+++ b/src/sys/setpag.c
@@ -17,6 +17,7 @@
 
 
 #include <afs/afs_args.h>
+#include <afs/sys_prototypes.h>
 #include <unistd.h>
 #include <stdio.h>
 #if !defined(AFS_AIX_ENV) && !defined(AFS_NT40_ENV) 

diff --git a/src/uss/grammar.y b/src/uss/grammar.y
index 2c3fede932a7cf8ef32ad3aef928dba173458c0c..7abb30c32218cc6ac65f1266f78ae3373357d338 100644 (file)
--- a/src/uss/grammar.y
+++ b/src/uss/grammar.y
@@ -15,6 +15,10 @@
 
 extern int line;
 extern int uss_perr;
+
+extern int yylex(void);
+extern int yyerror(char *);
+
 %}
 
 %union

diff --git a/src/venus/test/getinitparams.c b/src/venus/test/getinitparams.c
index 133f422fbb213bd8869c9a9445e01e3e91e3d603..16eb9a56630ddd5934b078d98cd7d345db2d4402 100644 (file)
--- a/src/venus/test/getinitparams.c
+++ b/src/venus/test/getinitparams.c
@@ -18,6 +18,7 @@
 #include <afs/vice.h>
 #include <afs/venus.h>
 #include <afs/cmd.h>
+#include <afs/sys_prototypes.h>
 #include <fcntl.h>
 #include <unistd.h>
 #ifdef AFS_AIX41_ENV

diff --git a/src/venus/up.c b/src/venus/up.c
index 7d9d11eb80ae98b408721ce60849a91a42165e2d..1cc7e7338d995db70b2d9f317afb033563114806 100644 (file)
--- a/src/venus/up.c
+++ b/src/venus/up.c
@@ -46,6 +46,7 @@
 
 #include <afs/venus.h>
 #include <afs/sys_prototypes.h>
+#include <afs/afsutil.h>
 
 /* ************************************************************* */
 

diff --git a/src/vol/fssync-debug.c b/src/vol/fssync-debug.c
index f8436e808c9dbc322583673e298eace5f35b7a8b..b48de7baebc0d3902086e46f549eed8da8219626 100644 (file)
--- a/src/vol/fssync-debug.c
+++ b/src/vol/fssync-debug.c
@@ -48,6 +48,7 @@
 #endif
 
 #include <afs/cmd.h>
+#include <afs/dir.h>
 #include <afs/afsutil.h>
 #include <afs/fileutil.h>
 

diff --git a/src/vol/salvager.c b/src/vol/salvager.c
index 8536aabda99004942e548dd7c34a01aea506dee8..f62abdb63cc2d6fb45c12cab06045737e59459b2 100644 (file)
--- a/src/vol/salvager.c
+++ b/src/vol/salvager.c
@@ -98,6 +98,7 @@
 #include <afs/osi_inode.h>
 #endif
 #include <afs/cmd.h>
+#include <afs/dir.h>
 #include <afs/afsutil.h>
 #include <afs/fileutil.h>
 #include <afs/procmgmt.h>      /* signal(), kill(), wait(), etc. */

diff --git a/src/vol/vol-info.c b/src/vol/vol-info.c
index a416f0bc19e579f33b0adda89cc5365c6dac2762..fcf0c511a053f529ef4dbf1247230bd353c1c7b4 100644 (file)
--- a/src/vol/vol-info.c
+++ b/src/vol/vol-info.c
@@ -33,6 +33,7 @@
 #include <sys/time.h>
 #endif
 #include <afs/cmd.h>
+#include <afs/dir.h>
 
 #include <rx/xdr.h>
 #include <afs/afsint.h>

diff --git a/src/vol/vol-salvage.c b/src/vol/vol-salvage.c
index e98b440bf0f9e4e6644f5be9e15d9dcb0287598a..270ef1e14481563b7aea4ed00cfbfbcc337e5ca7 100644 (file)
--- a/src/vol/vol-salvage.c
+++ b/src/vol/vol-salvage.c
@@ -165,6 +165,7 @@ Vnodes with 0 inode pointers in RW volumes are now deleted.
 #include <afs/osi_inode.h>
 #endif
 #include <afs/cmd.h>
+#include <afs/dir.h>
 #include <afs/afsutil.h>
 #include <afs/fileutil.h>
 #include <afs/procmgmt.h>      /* signal(), kill(), wait(), etc. */

diff --git a/src/volser/vol_split.c b/src/volser/vol_split.c
index 8af67eafcd1869a238b5336227617fa51d49252a..7a26910c26c24422fe61a13a64946d5283dc3067 100644 (file)
--- a/src/volser/vol_split.c
+++ b/src/volser/vol_split.c
@@ -37,6 +37,7 @@
 #include <errno.h>
 #include <sys/stat.h>
 
+#include <afs/dir.h>
 #include <rx/xdr.h>
 #include <afs/afsint.h>
 #include "nfs.h"

diff --git a/src/volser/volmain.c b/src/volser/volmain.c
index b17e783fe2b6d93b7ad792dfea12fff461e66483..ab0052c1ebd999919feef956521826fc261de5c8 100644 (file)
--- a/src/volser/volmain.c
+++ b/src/volser/volmain.c
@@ -50,6 +50,7 @@
 #include <afs/auth.h>
 #include <afs/cellconfig.h>
 #include <afs/keys.h>
+#include <afs/dir.h>
 #include <ubik.h>
 #include <fcntl.h>
 #include <sys/stat.h>