gcc 4.8: fix warnings

Quiet new warnings introduced by gcc 4.8:

- Many unused typedefs under src/admin.
- A possibly uninitialzed variable under src/viced

Reviewed-on: http://gerrit.openafs.org/8913
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 684d1ec6ba4bb7e96404328d02be5d070ba63478)

Change-Id: If887f461dc2bed37b342bb514334f0058b0aceda
Reviewed-on: http://gerrit.openafs.org/10242
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Mark Vitale <mvitale@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

diff --git a/src/libadmin/test/bos.c b/src/libadmin/test/bos.c
index 97bacbac77781bc098acff0b724705ef58de631b..2772082f9b59e24bbfccc59447df16ec7e57e4bc 100644 (file)
--- a/src/libadmin/test/bos.c
+++ b/src/libadmin/test/bos.c
@@ -272,9 +272,9 @@ ktime_ParsePeriodic(char *adate, bos_RestartTime_p ak)
 int
 DoBosProcessCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, BINARY, CRON, CRONTIME,
+    enum { SERVER, PROCESS, BINARY, CRON, CRONTIME,
        NOTIFIER
-    } DoBosProcessCreate_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -338,9 +338,9 @@ DoBosProcessCreate(struct cmd_syndesc *as, void *arock)
 int
 DoBosFSProcessCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, FILESERVER, VOLSERVER, SALVAGER,
+    enum { SERVER, PROCESS, FILESERVER, VOLSERVER, SALVAGER,
        NOTIFIER
-    } DoBosFSProcessCreate_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -390,7 +390,7 @@ DoBosFSProcessCreate(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoBosProcessDelete_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -439,7 +439,7 @@ Print_bos_ProcessExecutionState_p(bos_ProcessExecutionState_p state,
 int
 DoBosProcessExecutionStateGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoBosProcessExecutionStateGet_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -475,9 +475,9 @@ DoBosProcessExecutionStateGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessExecutionStateSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, STOPPED,
+    enum { SERVER, PROCESS, STOPPED,
        RUNNING
-    } DoBosProcessExecutionStateSet_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -526,9 +526,9 @@ DoBosProcessExecutionStateSet(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessExecutionStateSetTemporary(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, STOPPED,
+    enum { SERVER, PROCESS, STOPPED,
        RUNNING
-    } DoBosProcessExecutionStateSetTemporary_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -578,7 +578,7 @@ DoBosProcessExecutionStateSetTemporary(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessNameList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosProcessNameList_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
     void *iter = NULL;
@@ -667,7 +667,7 @@ Print_bos_ProcessInfo_p(bos_ProcessInfo_p info, const char *prefix)
 int
 DoBosProcessInfoGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoBosProcessInfoGet_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -698,7 +698,7 @@ DoBosProcessInfoGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessParameterList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoBosProcessParameterList_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     char *process = NULL;
@@ -742,7 +742,7 @@ DoBosProcessParameterList(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessNotifierGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoBosProcessNotifierGet_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -777,7 +777,7 @@ DoBosProcessNotifierGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessRestart(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoBosProcessRestart_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *process = NULL;
@@ -805,7 +805,7 @@ DoBosProcessRestart(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessAllStop(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosProcessAllStop_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
 
@@ -828,7 +828,7 @@ DoBosProcessAllStop(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessAllStart(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosProcessAllStart_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
 
@@ -851,7 +851,7 @@ DoBosProcessAllStart(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessAllWaitStop(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosProcessAllWaitStop_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
 
@@ -874,7 +874,7 @@ DoBosProcessAllWaitStop(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessAllWaitTransition(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosProcessAllWaitTransition_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
 
@@ -897,7 +897,7 @@ DoBosProcessAllWaitTransition(struct cmd_syndesc *as, void *arock)
 int
 DoBosProcessAllStopAndRestart(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, INCLUDEBOS } DoBosProcessAllStopAndRestart_parm_t;
+    enum { SERVER, INCLUDEBOS };
     afs_status_t st = 0;
     void *bos_server = NULL;
     bos_RestartBosServer_t restart = BOS_DONT_RESTART_BOS_SERVER;
@@ -925,7 +925,7 @@ DoBosProcessAllStopAndRestart(struct cmd_syndesc *as, void *arock)
 int
 DoBosAdminCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, ADMIN } DoBosAdminCreate_parm_t;
+    enum { SERVER, ADMIN };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *admin = NULL;
@@ -953,7 +953,7 @@ DoBosAdminCreate(struct cmd_syndesc *as, void *arock)
 int
 DoBosAdminDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, ADMIN } DoBosAdminDelete_parm_t;
+    enum { SERVER, ADMIN };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *admin = NULL;
@@ -981,7 +981,7 @@ DoBosAdminDelete(struct cmd_syndesc *as, void *arock)
 int
 DoBosAdminList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosAdminList_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
     void *iter = NULL;
@@ -1020,7 +1020,7 @@ DoBosAdminList(struct cmd_syndesc *as, void *arock)
 int
 DoBosKeyCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, VERSIONNUMBER, KEY } DoBosKeyCreate_parm_t;
+    enum { SERVER, VERSIONNUMBER, KEY };
     afs_status_t st = 0;
     void *bos_server = NULL;
     int version_number = 0;
@@ -1062,7 +1062,7 @@ DoBosKeyCreate(struct cmd_syndesc *as, void *arock)
 int
 DoBosKeyDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, VERSIONNUMBER } DoBosKeyDelete_parm_t;
+    enum { SERVER, VERSIONNUMBER };
     afs_status_t st = 0;
     void *bos_server = NULL;
     int version_number = 0;
@@ -1110,7 +1110,7 @@ Print_bos_KeyInfo_p(bos_KeyInfo_p key, const char *prefix)
 int
 DoBosKeyList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosKeyList_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
     void *iter = NULL;
@@ -1149,7 +1149,7 @@ DoBosKeyList(struct cmd_syndesc *as, void *arock)
 int
 DoBosCellSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, CELL } DoBosCellSet_parm_t;
+    enum { SERVER, CELL };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *cell = NULL;
@@ -1177,7 +1177,7 @@ DoBosCellSet(struct cmd_syndesc *as, void *arock)
 int
 DoBosCellGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosCellGet_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
     char cell[BOS_MAX_NAME_LEN];
@@ -1203,7 +1203,7 @@ DoBosCellGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosHostCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, HOST } DoBosHostCreate_parm_t;
+    enum { SERVER, HOST };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *host = NULL;
@@ -1231,7 +1231,7 @@ DoBosHostCreate(struct cmd_syndesc *as, void *arock)
 int
 DoBosHostDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, HOST } DoBosHostDelete_parm_t;
+    enum { SERVER, HOST };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *host = NULL;
@@ -1259,7 +1259,7 @@ DoBosHostDelete(struct cmd_syndesc *as, void *arock)
 int
 DoBosHostList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoBosHostList_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *bos_server = NULL;
     void *iter = NULL;
@@ -1299,7 +1299,7 @@ DoBosHostList(struct cmd_syndesc *as, void *arock)
 int
 DoBosExecutableCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, BINARY, DEST } DoBosExecutableCreate_parm_t;
+    enum { SERVER, BINARY, DEST };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *binary = NULL;
@@ -1332,7 +1332,7 @@ DoBosExecutableCreate(struct cmd_syndesc *as, void *arock)
 int
 DoBosExecutableRevert(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, EXECUTABLE } DoBosExecutableRevert_parm_t;
+    enum { SERVER, EXECUTABLE };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *executable = NULL;
@@ -1360,7 +1360,7 @@ DoBosExecutableRevert(struct cmd_syndesc *as, void *arock)
 int
 DoBosExecutableTimestampGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, EXECUTABLE } DoBosExecutableTimestampGet_parm_t;
+    enum { SERVER, EXECUTABLE };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *executable = NULL;
@@ -1392,9 +1392,9 @@ DoBosExecutableTimestampGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosExecutablePrune(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, OLDFILES, BAKFILES,
+    enum { SERVER, OLDFILES, BAKFILES,
        COREFILES
-    } DoBosExecutablePrune_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     bos_Prune_t old_files = BOS_DONT_PRUNE;
@@ -1433,9 +1433,9 @@ DoBosExecutablePrune(struct cmd_syndesc *as, void *arock)
 int
 DoBosExecutableRestartTimeSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, DAILY, WEEKLY,
+    enum { SERVER, DAILY, WEEKLY,
        TIME
-    } DoBosExecutableRestartTimeSet_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     bos_Restart_t type = 0;
@@ -1532,9 +1532,9 @@ Print_bos_RestartTime_p(bos_RestartTime_p restart, const char *prefix)
 int
 DoBosExecutableRestartTimeGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, DAILY,
+    enum { SERVER, DAILY,
        WEEKLY
-    } DoBosExecutableRestartTimeGet_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     bos_Restart_t type = 0;
@@ -1583,7 +1583,7 @@ DoBosExecutableRestartTimeGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosLogGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, LOGFILE } DoBosLogGet_parm_t;
+    enum { SERVER, LOGFILE };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *log_file = NULL;
@@ -1631,7 +1631,7 @@ DoBosLogGet(struct cmd_syndesc *as, void *arock)
 int
 DoBosAuthSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, REQUIREAUTH, DISABLEAUTH } DoBosAuthSet_parm_t;
+    enum { SERVER, REQUIREAUTH, DISABLEAUTH };
     afs_status_t st = 0;
     void *bos_server = NULL;
     bos_Auth_t auth = 0;
@@ -1675,7 +1675,7 @@ DoBosAuthSet(struct cmd_syndesc *as, void *arock)
 int
 DoBosCommandExecute(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, COMMAND } DoBosCommandExecute_parm_t;
+    enum { SERVER, COMMAND };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *command = NULL;
@@ -1703,9 +1703,9 @@ DoBosCommandExecute(struct cmd_syndesc *as, void *arock)
 int
 DoBosSalvage(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME, NUMSALVAGERS, TMPDIR, LOGFILE,
+    enum { SERVER, PARTITION, VOLUME, NUMSALVAGERS, TMPDIR, LOGFILE,
        FORCE, NOWRITE, INODES, ROOTINODES, SALVAGEDIRS, BLOCKREADS
-    } DoBosSalvage_parm_t;
+    };
     afs_status_t st = 0;
     void *bos_server = NULL;
     const char *partition = NULL;

diff --git a/src/libadmin/test/client.c b/src/libadmin/test/client.c
index 2180d410feb045b1a172e3e0e4fd2c0a30301cec..9e753bf8f33dfad6fffa6af555d61dd510c2c5e4 100644 (file)
--- a/src/libadmin/test/client.c
+++ b/src/libadmin/test/client.c
@@ -264,9 +264,9 @@ DoClientLocalCellGet(struct cmd_syndesc *as, void *arock)
 int
 DoClientMountPointCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { DIRECTORY, VOLUME, READWRITE,
+    enum { DIRECTORY, VOLUME, READWRITE,
        CHECK
-    } DoClientMountPointCreate_parm_t;
+    };
     afs_status_t st = 0;
     const char *directory = NULL;
     const char *volume = NULL;
@@ -318,7 +318,7 @@ Print_afs_serverEntry_p(afs_serverEntry_p serv, const char *prefix)
 int
 DoClientAFSServerGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoClientAFSServerGet_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     const char *server = NULL;
     afs_serverEntry_t entry;
@@ -463,9 +463,9 @@ GetStatTypeFromString(const char *type)
 int
 DoClientRPCStatsStateGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS,
+    enum { SERVER, PROCESS,
        STAT_TYPE
-    } DoClientRPCStatsStateGet_parm_t;
+    };
     afs_status_t st = 0;
     struct rx_connection *conn;
     afs_stat_source_t type;
@@ -522,7 +522,7 @@ DoClientRPCStatsStateGet(struct cmd_syndesc *as, void *arock)
 int
 DoClientRPCStatsStateEnable(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, STAT_TYPE } DoClientRPCStatsEnable_parm_t;
+    enum { SERVER, PROCESS, STAT_TYPE };
     afs_status_t st = 0;
     struct rx_connection *conn;
     afs_stat_source_t type;
@@ -575,9 +575,9 @@ DoClientRPCStatsStateEnable(struct cmd_syndesc *as, void *arock)
 int
 DoClientRPCStatsStateDisable(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS,
+    enum { SERVER, PROCESS,
        STAT_TYPE
-    } DoClientRPCStatsDisable_parm_t;
+    };
     afs_status_t st = 0;
     struct rx_connection *conn;
     afs_stat_source_t type;
@@ -678,7 +678,7 @@ Print_afs_RPCStats_p(afs_RPCStats_p stat, interface_function_list_p f_list,
 int
 DoClientRPCStatsList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, STAT_TYPE } DoClientRPCStatsList_parm_t;
+    enum { SERVER, PROCESS, STAT_TYPE };
     afs_status_t st = 0;
     struct rx_connection *conn;
     afs_stat_source_t type;
@@ -802,13 +802,13 @@ DoClientRPCStatsList(struct cmd_syndesc *as, void *arock)
 int
 DoClientRPCStatsClear(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS, STAT_TYPE, CLEAR_ALL, CLEAR_INVOCATIONS,
+    enum { SERVER, PROCESS, STAT_TYPE, CLEAR_ALL, CLEAR_INVOCATIONS,
        CLEAR_BYTES_SENT, CLEAR_BYTES_RCVD,
        CLEAR_QUEUE_TIME_SUM, CLEAR_QUEUE_TIME_SQUARE,
        CLEAR_QUEUE_TIME_MIN, CLEAR_QUEUE_TIME_MAX,
        CLEAR_EXEC_TIME_SUM, CLEAR_EXEC_TIME_SQUARE,
        CLEAR_EXEC_TIME_MIN, CLEAR_EXEC_TIME_MAX
-    } DoClientRPCStatsClear_parm_t;
+    };
     afs_status_t st = 0;
     struct rx_connection *conn;
     afs_stat_source_t type;
@@ -973,7 +973,7 @@ DoClientRPCStatsClear(struct cmd_syndesc *as, void *arock)
 int
 DoClientRPCStatsVersionGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PROCESS } DoClientRPCStatsVersionGet_parm_t;
+    enum { SERVER, PROCESS };
     afs_status_t st = 0;
     struct rx_connection *conn;
     afs_stat_source_t type;
@@ -1029,7 +1029,7 @@ int
 DoClientCMGetServerPrefs(struct cmd_syndesc *as, void *arock)
 {
     afs_status_t st = 0;
-    typedef enum { SERVER, PORT } DoClientCMGetServerPrefs_parm_t;
+    enum { SERVER, PORT };
     struct rx_connection *conn;
     int srvrPort = AFSCONF_CALLBACKPORT;
     afs_CMServerPref_t prefs;
@@ -1098,7 +1098,7 @@ int
 DoClientCMListCells(struct cmd_syndesc *as, void *arock)
 {
     afs_status_t st = 0;
-    typedef enum { SERVER, PORT } DoClientCMListCells_parm_t;
+    enum { SERVER, PORT };
     struct rx_connection *conn;
     int srvrPort = AFSCONF_CALLBACKPORT;
     afs_CMListCell_t cellInfo;
@@ -1152,7 +1152,7 @@ int
 DoClientCMLocalCell(struct cmd_syndesc *as, void *arock)
 {
     afs_status_t st = 0;
-    typedef enum { SERVER, PORT } DoClientCMLocalCell_parm_t;
+    enum { SERVER, PORT };
     struct rx_connection *conn;
     int srvrPort = AFSCONF_CALLBACKPORT;
     afs_CMCellName_t cellname;
@@ -1210,7 +1210,7 @@ int
 DoClientCMClientConfig(struct cmd_syndesc *as, void *arock)
 {
     afs_status_t st = 0;
-    typedef enum { SERVER, PORT } DoClientCMLocalCell_parm_t;
+    enum { SERVER, PORT };
     struct rx_connection *conn;
     int srvrPort = AFSCONF_CALLBACKPORT;
     afs_ClientConfig_t config;

diff --git a/src/libadmin/test/kas.c b/src/libadmin/test/kas.c
index f5dcd2c9462933c4c2feb5da8dfe2d70bf0b7d08..c6398b7f77d130516bb55e897bfd8b735f2b2df8 100644 (file)
--- a/src/libadmin/test/kas.c
+++ b/src/libadmin/test/kas.c
@@ -45,9 +45,9 @@ GetIntFromString(const char *int_str, const char *error_msg)
 int
 DoKasPrincipalCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE,
+    enum { PRINCIPAL, INSTANCE,
        PASSWORD
-    } DoKasPrincipalCreate_parm_t;
+    };
     afs_status_t st = 0;
     kas_identity_t user;
     const char *password;
@@ -72,7 +72,7 @@ DoKasPrincipalCreate(struct cmd_syndesc *as, void *arock)
 int
 DoKasPrincipalDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE } DoKasPrincipalGet_parm_t;
+    enum { PRINCIPAL, INSTANCE };
     afs_status_t st = 0;
     kas_identity_t user;
 
@@ -158,7 +158,7 @@ Print_kas_principalEntry_p(kas_principalEntry_p principal, const char *prefix)
 int
 DoKasPrincipalGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE } DoKasPrincipalGet_parm_t;
+    enum { PRINCIPAL, INSTANCE };
     afs_status_t st = 0;
     kas_identity_t user;
     kas_principalEntry_t principal;
@@ -215,9 +215,9 @@ DoKasPrincipalList(struct cmd_syndesc *as, void *arock)
 int
 DoKasPrincipalKeySet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE, PASSWORD,
+    enum { PRINCIPAL, INSTANCE, PASSWORD,
        KEYVERSION
-    } DoKasPrincipalKeySet_parm_t;
+    };
     afs_status_t st = 0;
     kas_encryptionKey_t key;
     kas_identity_t user;
@@ -255,7 +255,7 @@ DoKasPrincipalKeySet(struct cmd_syndesc *as, void *arock)
 int
 DoKasPrincipalLockStatusGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE } DoKasPrincipalLockStatusGet_parm_t;
+    enum { PRINCIPAL, INSTANCE };
     afs_status_t st = 0;
     kas_identity_t user;
     unsigned int lock_end_time = 0;
@@ -281,7 +281,7 @@ DoKasPrincipalLockStatusGet(struct cmd_syndesc *as, void *arock)
 int
 DoKasPrincipalUnlock(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE } DoKasPrincipalUnlock_parm_t;
+    enum { PRINCIPAL, INSTANCE };
     afs_status_t st = 0;
     kas_identity_t user;
 
@@ -303,12 +303,12 @@ DoKasPrincipalUnlock(struct cmd_syndesc *as, void *arock)
 int
 DoKasPrincipalFieldsSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PRINCIPAL, INSTANCE, ADMIN, NOADMIN, GRANTTICKET,
+    enum { PRINCIPAL, INSTANCE, ADMIN, NOADMIN, GRANTTICKET,
        NOGRANTTICKET, ENCRYPT2, NOENCRYPT, CHANGEPASSWORD,
        NOCHANGEPASSWORD, REUSEPASSWORD, NOREUSEPASSWORD,
        EXPIRES, MAXTICKETLIFETIME, PASSWORDEXPIRES,
        FAILEDPASSWORDATTEMPTS, FAILEDPASSWORDLOCKTIME
-    } DoKasPrincipalFieldsSet_parm_t;
+    };
     afs_status_t st = 0;
     kas_identity_t user;
     kas_admin_t admin;
@@ -545,7 +545,7 @@ Print_kas_serverStats_p(kas_serverStats_p stats, const char *prefix)
 int
 DoKasServerStatsGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoKasServerStatsGet_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     const char *server_list[2] = { 0, 0 };
     void *kas_server = NULL;
@@ -630,7 +630,7 @@ Print_kas_serverDebugInfo_p(kas_serverDebugInfo_p debug, const char *prefix)
 int
 DoKasServerDebugGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoKasServerDebugGet_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     const char *server_list[2] = { 0, 0 };
     void *kas_server = NULL;

diff --git a/src/libadmin/test/pts.c b/src/libadmin/test/pts.c
index 7d7a2022dcfdec76e6259bd863fd18108dc05129..3a0541b2bf43fed303a4f6959d086b4059c54be9 100644 (file)
--- a/src/libadmin/test/pts.c
+++ b/src/libadmin/test/pts.c
@@ -90,7 +90,7 @@ GetUserAccessFromString(const char *in_str, const char *error_msg)
 int
 DoPtsGroupMemberAdd(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER, GROUP } DoPtsGroupMemberAdd_parm_t;
+    enum { USER, GROUP };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     const char *group = as->parms[GROUP].items->data;
@@ -105,7 +105,7 @@ DoPtsGroupMemberAdd(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupOwnerChange(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { OWNER, GROUP } DoPtsGroupOwnerChange_parm_t;
+    enum { OWNER, GROUP };
     afs_status_t st = 0;
     const char *owner = as->parms[OWNER].items->data;
     const char *group = as->parms[GROUP].items->data;
@@ -120,7 +120,7 @@ DoPtsGroupOwnerChange(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { OWNER, GROUP } DoPtsGroupCreate_parm_t;
+    enum { OWNER, GROUP };
     afs_status_t st = 0;
     char *owner = as->parms[OWNER].items->data;
     char *group = as->parms[GROUP].items->data;
@@ -170,7 +170,7 @@ Print_pts_GroupEntry_p(pts_GroupEntry_p entry, const char *prefix)
 int
 DoPtsGroupGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { GROUP } DoPtsGroupGet_parm_t;
+    enum { GROUP };
     afs_status_t st = 0;
     const char *group = as->parms[GROUP].items->data;
     pts_GroupEntry_t entry;
@@ -187,7 +187,7 @@ DoPtsGroupGet(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { GROUP } DoPtsGroupDelete_parm_t;
+    enum { GROUP };
     afs_status_t st = 0;
     const char *group = as->parms[GROUP].items->data;
 
@@ -214,7 +214,7 @@ DoPtsGroupMaxGet(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupMaxSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { MAX } DoPtsGroupMaxSet_parm_t;
+    enum { MAX };
     afs_status_t st = 0;
     const char *max = as->parms[MAX].items->data;
     int max_group_id;
@@ -231,7 +231,7 @@ DoPtsGroupMaxSet(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupMemberList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { GROUP } DoPtsGroupMemberList_parm_t;
+    enum { GROUP };
     afs_status_t st = 0;
     const char *group = as->parms[GROUP].items->data;
     void *iter;
@@ -260,7 +260,7 @@ DoPtsGroupMemberList(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupMemberRemove(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER, GROUP } DoPtsGroupMemberRemove_parm_t;
+    enum { USER, GROUP };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     const char *group = as->parms[GROUP].items->data;
@@ -275,7 +275,7 @@ DoPtsGroupMemberRemove(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupRename(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { GROUP, NEWNAME } DoPtsGroupRename_parm_t;
+    enum { GROUP, NEWNAME };
     afs_status_t st = 0;
     const char *group = as->parms[GROUP].items->data;
     char *new_name = as->parms[NEWNAME].items->data;
@@ -290,9 +290,9 @@ DoPtsGroupRename(struct cmd_syndesc *as, void *arock)
 int
 DoPtsGroupModify(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { GROUP, LISTSTATUS, LISTGROUPSOWNED, LISTMEMBERSHIP,
+    enum { GROUP, LISTSTATUS, LISTGROUPSOWNED, LISTMEMBERSHIP,
        LISTADD, LISTDELTE
-    } DoPtsGroupModify_parm_t;
+    };
     afs_status_t st = 0;
     const char *group = as->parms[GROUP].items->data;
     pts_GroupUpdateEntry_t entry;
@@ -323,7 +323,7 @@ DoPtsGroupModify(struct cmd_syndesc *as, void *arock)
 int
 DoPtsUserCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER } DoPtsUserCreate_parm_t;
+    enum { USER };
     afs_status_t st = 0;
     char *user = as->parms[USER].items->data;
     int new_user_id;
@@ -340,7 +340,7 @@ DoPtsUserCreate(struct cmd_syndesc *as, void *arock)
 int
 DoPtsUserDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER } DoPtsUserDelete_parm_t;
+    enum { USER };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
 
@@ -383,7 +383,7 @@ Print_pts_UserEntry_p(pts_UserEntry_p entry, const char *prefix)
 int
 DoPtsUserGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER } DoPtsUserGet_parm_t;
+    enum { USER };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     pts_UserEntry_t entry;
@@ -400,7 +400,7 @@ DoPtsUserGet(struct cmd_syndesc *as, void *arock)
 int
 DoPtsUserRename(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER, NEWNAME } DoPtsUserRename_parm_t;
+    enum { USER, NEWNAME };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     char *new_name = as->parms[NEWNAME].items->data;
@@ -415,9 +415,9 @@ DoPtsUserRename(struct cmd_syndesc *as, void *arock)
 int
 DoPtsUserModify(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER, GROUPQUOTA, LISTSTATUS, LISTGROUPSOWNED,
+    enum { USER, GROUPQUOTA, LISTSTATUS, LISTGROUPSOWNED,
        LISTMEMBERSHIP
-    } DoPtsUserModify_parm_t;
+    };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     pts_UserUpdateEntry_t entry;
@@ -492,7 +492,7 @@ DoPtsUserMaxGet(struct cmd_syndesc *as, void *arock)
 int
 DoPtsUserMaxSet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { MAX } DoPtsUserMaxSet_parm_t;
+    enum { MAX };
     afs_status_t st = 0;
     const char *max = as->parms[MAX].items->data;
     int max_user_id;
@@ -509,7 +509,7 @@ DoPtsUserMaxSet(struct cmd_syndesc *as, void *arock)
 int
 DoPtsUserMemberList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER } DoPtsUserMemberList_parm_t;
+    enum { USER };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     void *iter;
@@ -539,7 +539,7 @@ DoPtsUserMemberList(struct cmd_syndesc *as, void *arock)
 int
 DoPtsOwnedGroupList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { USER } DoPtsOwnedGroupList_parm_t;
+    enum { USER };
     afs_status_t st = 0;
     const char *user = as->parms[USER].items->data;
     void *iter;

diff --git a/src/libadmin/test/util.c b/src/libadmin/test/util.c
index e9c5cd21449884c87a5d0c3832bc2f655a26d69a..52d63f271b0eae4c4ece5933c201007e46ec68dc 100644 (file)
--- a/src/libadmin/test/util.c
+++ b/src/libadmin/test/util.c
@@ -20,7 +20,7 @@
 int
 DoUtilErrorTranslate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { ERROR_CODE } DoUtilErrorTranslate_parm_t;
+    enum { ERROR_CODE };
     afs_status_t st = 0;
     int err = atoi(as->parms[ERROR_CODE].items->data);
     const char *err_str = "unknown error";
@@ -37,7 +37,7 @@ DoUtilErrorTranslate(struct cmd_syndesc *as, void *arock)
 int
 DoUtilDatabaseServerList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { CELL_NAME } DoUtilDatabaseServerList_parm_t;
+    enum { CELL_NAME };
     afs_status_t st = 0;
     void *iter = NULL;
     util_databaseServerEntry_t server;
@@ -66,7 +66,7 @@ DoUtilDatabaseServerList(struct cmd_syndesc *as, void *arock)
 int
 DoUtilNameToAddress(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER_NAME } DoUtilNameToAddress_parm_t;
+    enum { SERVER_NAME };
     afs_status_t st = 0;
     const char *server = as->parms[SERVER_NAME].items->data;
     int server_addr = 0;

diff --git a/src/libadmin/test/vos.c b/src/libadmin/test/vos.c
index 6aa8338ce97c1e63e401be5166009610614726c4..2892e400e14f8695222f68bc9be3920216a4247d 100644 (file)
--- a/src/libadmin/test/vos.c
+++ b/src/libadmin/test/vos.c
@@ -150,7 +150,7 @@ PrintMessage(vos_messageType_t type, char *message)
 int
 DoVosBackupVolumeCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { VOLUME } DoVosBackupVolumeCreate_parm_t;
+    enum { VOLUME };
     afs_status_t st = 0;
     unsigned int volume_id = 0;
 
@@ -168,9 +168,9 @@ DoVosBackupVolumeCreate(struct cmd_syndesc *as, void *arock)
 int
 DoVosBackupVolumeCreateMultiple(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, PREFIX,
+    enum { SERVER, PARTITION, PREFIX,
        EXCLUDE
-    } DoVosBackupVolumeCreate_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -220,7 +220,7 @@ Print_vos_partitionEntry_p(vos_partitionEntry_p part, const char *prefix)
 int
 DoVosPartitionGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION } DoVosPartitionGet_parm_t;
+    enum { SERVER, PARTITION };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -251,7 +251,7 @@ DoVosPartitionGet(struct cmd_syndesc *as, void *arock)
 int
 DoVosPartitionList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoVosPartitionGet_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *vos_server = NULL;
     void *iter;
@@ -287,7 +287,7 @@ DoVosPartitionList(struct cmd_syndesc *as, void *arock)
 int
 DoVosServerSync(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION } DoVosServerSync_parm_t;
+    enum { SERVER, PARTITION };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -315,9 +315,9 @@ DoVosServerSync(struct cmd_syndesc *as, void *arock)
 int
 DoVosFileServerAddressChange(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { OLDADDRESS,
+    enum { OLDADDRESS,
        NEWADDRESS
-    } DoVosFileServerAddressChange_parm_t;
+    };
     afs_status_t st = 0;
     int old_addr = 0;
     int new_addr = 0;
@@ -341,7 +341,7 @@ DoVosFileServerAddressChange(struct cmd_syndesc *as, void *arock)
 int
 DoVosFileServerAddressRemove(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { ADDRESS } DoVosFileServerAddressRemove_parm_t;
+    enum { ADDRESS };
     afs_status_t st = 0;
     int address = 0;
 
@@ -421,7 +421,7 @@ Print_vos_serverTransactionStatus_p(vos_serverTransactionStatus_p tran,
 int
 DoVosServerTransactionStatusList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER } DoVosServerTransactionStatusList_parm_t;
+    enum { SERVER };
     afs_status_t st = 0;
     void *vos_server = NULL;
     void *iter = NULL;
@@ -529,7 +529,7 @@ Print_vos_vldbEntry_p(vos_vldbEntry_p entry, const char *prefix)
 int
 DoVosVLDBGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { VOLUME } DoVosVLDBGet_parm_t;
+    enum { VOLUME };
     afs_status_t st = 0;
     vos_vldbEntry_t entry;
     unsigned int volume_id;
@@ -553,7 +553,7 @@ DoVosVLDBGet(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION } DoVosVLDBList_parm_t;
+    enum { SERVER, PARTITION };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -601,7 +601,7 @@ DoVosVLDBList(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBEntryRemove(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME } DoVosVLDBEntryRemove_parm_t;
+    enum { SERVER, PARTITION, VOLUME };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -644,7 +644,7 @@ DoVosVLDBEntryRemove(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBUnlock(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION } DoVosVLDBUnlock_parm_t;
+    enum { SERVER, PARTITION };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -678,7 +678,7 @@ DoVosVLDBUnlock(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBEntryLock(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { VOLUME } DoVosVLDBEntryLoc_parm_tk;
+    enum { VOLUME };
     afs_status_t st = 0;
     unsigned int volume_id = 0;
 
@@ -697,7 +697,7 @@ DoVosVLDBEntryLock(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBEntryUnlock(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { VOLUME } DoVosVLDBEntryUnlock_parm_t;
+    enum { VOLUME };
     afs_status_t st = 0;
     unsigned int volume_id = 0;
 
@@ -716,9 +716,9 @@ DoVosVLDBEntryUnlock(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBReadOnlySiteCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION,
+    enum { SERVER, PARTITION,
        VOLUME
-    } DoVosVLDBReadOnlySiteCreate_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -751,9 +751,9 @@ DoVosVLDBReadOnlySiteCreate(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBReadOnlySiteDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION,
+    enum { SERVER, PARTITION,
        VOLUME
-    } DoVosVLDBReadOnlySiteDelete_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -787,7 +787,7 @@ DoVosVLDBReadOnlySiteDelete(struct cmd_syndesc *as, void *arock)
 int
 DoVosVLDBSync(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, FORCE } DoVosVLDBSync_parm_t;
+    enum { SERVER, PARTITION, FORCE };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -826,9 +826,9 @@ DoVosVLDBSync(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeCreate(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME,
+    enum { SERVER, PARTITION, VOLUME,
        QUOTA
-    } DoVosVolumeCreate_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -871,7 +871,7 @@ DoVosVolumeCreate(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeDelete(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME } DoVosVolumeDelete_parm_t;
+    enum { SERVER, PARTITION, VOLUME };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -905,7 +905,7 @@ DoVosVolumeDelete(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeRename(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { OLDVOLUME, NEWVOLUME } DoVosVolumeRename_parm_t;
+    enum { OLDVOLUME, NEWVOLUME };
     afs_status_t st = 0;
     unsigned int old_volume = 0;
     char *new_volume = NULL;
@@ -929,9 +929,9 @@ DoVosVolumeRename(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeDump(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME, STARTTIME,
+    enum { SERVER, PARTITION, VOLUME, STARTTIME,
        DUMPFILE
-    } DoVosVolumeDump_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id;
@@ -985,9 +985,9 @@ DoVosVolumeDump(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeRestore(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, ID, VOLUME, DUMPFILE,
+    enum { SERVER, PARTITION, ID, VOLUME, DUMPFILE,
        FULL
-    } DoVosVolumeRestore_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -1039,9 +1039,9 @@ DoVosVolumeRestore(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeOnline(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME, SLEEP,
+    enum { SERVER, PARTITION, VOLUME, SLEEP,
        BUSY
-    } DoVosVolumeOnline_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -1087,7 +1087,7 @@ DoVosVolumeOnline(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeOffline(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME } DoVosVolumeOffline_parm_t;
+    enum { SERVER, PARTITION, VOLUME };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -1344,7 +1344,7 @@ Print_vos_volumeEntry_p(vos_volumeEntry_p entry, const char *prefix)
 int
 DoVosVolumeGet(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME } DoVosVolumeGet_parm_t;
+    enum { SERVER, PARTITION, VOLUME };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -1381,7 +1381,7 @@ DoVosVolumeGet(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeList(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION } DoVosVolumeList_parm_t;
+    enum { SERVER, PARTITION };
     afs_status_t st = 0;
     void *vos_server = NULL;
     void *iter = NULL;
@@ -1427,9 +1427,9 @@ DoVosVolumeList(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeMove(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { VOLUME, FROMSERVER, FROMPARTITION, TOSERVER,
+    enum { VOLUME, FROMSERVER, FROMPARTITION, TOSERVER,
        TOPARTITION
-    } DoVosVolumeMove_parm_t;
+    };
     afs_status_t st = 0;
     void *from_server = NULL;
     void *to_server = NULL;
@@ -1479,7 +1479,7 @@ DoVosVolumeMove(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeRelease(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { VOLUME, FORCE } DoVosVolumeRelease_parm_t;
+    enum { VOLUME, FORCE };
     afs_status_t st = 0;
     unsigned int volume_id = 0;
     vos_force_t force = VOS_NORMAL;
@@ -1502,7 +1502,7 @@ DoVosVolumeRelease(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeZap(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME, FORCE } DoVosVolumeZap_parm_t;
+    enum { SERVER, PARTITION, VOLUME, FORCE };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -1541,7 +1541,7 @@ DoVosVolumeZap(struct cmd_syndesc *as, void *arock)
 int
 DoVosPartitionNameToId(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PARTITION } DoVosPartitionNameToId_parm_t;
+    enum { PARTITION };
     unsigned int partition_id = 0;
 
     if (as->parms[PARTITION].items) {
@@ -1558,7 +1558,7 @@ DoVosPartitionNameToId(struct cmd_syndesc *as, void *arock)
 int
 DoVosPartitionIdToName(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { PARTITIONID } DoVosPartitionIdToName_parm_t;
+    enum { PARTITIONID };
     afs_status_t st = 0;
     unsigned int partition_id = 0;
     char partition[VOS_MAX_PARTITION_NAME_LEN];
@@ -1581,9 +1581,9 @@ DoVosPartitionIdToName(struct cmd_syndesc *as, void *arock)
 int
 DoVosVolumeQuotaChange(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME,
+    enum { SERVER, PARTITION, VOLUME,
        QUOTA
-    } DoVosVolumeQuotaChange_parm_t;
+    };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;
@@ -1743,7 +1743,7 @@ Print_vos_volintInfo(afs_uint32 server, afs_uint32 partition, volintInfo* pinfo,
 int
 DoVosVolumeGet2(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME } DoVosVolumeGet_parm_t;
+    enum { SERVER, PARTITION, VOLUME };
     afs_status_t st = 0;
     void *vos_server = NULL;
     afs_uint32 partition_id = 0;
@@ -1785,7 +1785,7 @@ DoVosVolumeGet2(struct cmd_syndesc *as, void *arock)
 int
 DoVos_ClearVolUpdateCounter(struct cmd_syndesc *as, void *arock)
 {
-    typedef enum { SERVER, PARTITION, VOLUME } DoVosVolumeGet_parm_t;
+    enum { SERVER, PARTITION, VOLUME };
     afs_status_t st = 0;
     void *vos_server = NULL;
     unsigned int partition_id = 0;

diff --git a/src/viced/afsfileprocs.c b/src/viced/afsfileprocs.c
index 8e2b07bbb0b1a36445346711a90e55afad3879a5..2d86ea9f6e3b8f3fe4cfad9fddc2db20243eaec6 100644 (file)
--- a/src/viced/afsfileprocs.c
+++ b/src/viced/afsfileprocs.c
@@ -854,7 +854,7 @@ GetVolumePackage(struct rx_call *acall, AFSFid * Fid, Volume ** volptr,
                 struct client **client, int locktype, afs_int32 * rights,
                 afs_int32 * anyrights)
 {
-    struct acl_accessList *aCL;        /* Internal access List */
+    struct acl_accessList *aCL = NULL; /* Internal access List */
     int aCLSize;               /* size of the access list */
     Error errorCode = 0;               /* return code to caller */
     struct rx_connection *tcon = rx_ConnectionOf(acall);