When creating a ssl connection an attribute error can be thrown

This error is not catched and stops loop_forever etc., that is very
unexpected. So we catch the error and raise a error that is actually
catched (and better represents the situation)

See also: http://bugs.python.org/issue13721

Change-Id: I495c08ec079290a97caeaf0e7f88116041d8cec6
Signed-off-by: Hmvp <hmvp@hmvp.nl>

diff --git a/src/paho/mqtt/client.py b/src/paho/mqtt/client.py
index 9bbde8a504511bc630fb426be915bd12feda267d..ec02cbd1acea62f8ba49760056e5e274587876b0 100755 (executable)
--- a/src/paho/mqtt/client.py
+++ b/src/paho/mqtt/client.py
@@ -2304,7 +2304,13 @@ class Client(object):
                 return False
 
     def _tls_match_hostname(self):
-        cert = self._ssl.getpeercert()
+        try:
+            cert = self._ssl.getpeercert()
+        except AttributeError:
+            # the getpeercert can throw Attribute error: object has no attribute 'peer_certificate'
+            # Don't let that crash the whole client. See also: http://bugs.python.org/issue13721
+            raise ssl.SSLError('Not connected')
+
         san = cert.get('subjectAltName')
         if san:
             have_san_dns = False