windows: terminate multi_sz correctly

CreateProcess requires a null-terminated list of null-terminated strings
as an environment parameter.

A missing level of indirection was causing the final null to be
missed, meaning that if bosserver ran from somewhere which had an
environment the create process would fail.

Fix the null termination.

Change-Id: I3496d1c76570b80c760d0c0d8ee7fe046cec75b6
Reviewed-on: http://gerrit.openafs.org/3193
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>

diff --git a/src/procmgmt/procmgmt_nt.c b/src/procmgmt/procmgmt_nt.c
index 8f16c21c3bfb166fb86b86313f5ad36f6e354479..c7d351b4111cbac714d396d9c271bd10de96f60c 100644 (file)
--- a/src/procmgmt/procmgmt_nt.c
+++ b/src/procmgmt/procmgmt_nt.c
@@ -609,7 +609,7 @@ StringArrayToMultiString(char *strArray[])
                    bufp += strLen + 1;
                }
            }
-           bufp = '\0';        /* terminate multistring */
+           *bufp = '\0';       /* terminate multistring */
        }
     }