gcc-warnings-cleanup-20030701

FIXES 1650

add headers, cleanup castings

diff --git a/src/afsd/afsd.c b/src/afsd/afsd.c
index af5773b49002f0cd9063fa841af6cffc0fab0b3a..7b06b1dfac5257b2ea8b9675a1c1afbf6b85815c 100644 (file)
--- a/src/afsd/afsd.c
+++ b/src/afsd/afsd.c
@@ -2177,7 +2177,7 @@ long param1, param2, param3, param4, param5, param6, param7;
     eparm[2] = param6;
     eparm[3] = param7;
 
-    param4 = eparm;
+    param4 = (long) eparm;
 #endif
 
     error = syscall(AFS_SYSCALL, AFSCALL_CALL, param1, param2, param3, param4, param5, param6, param7);

diff --git a/src/bozo/bos_util.c b/src/bozo/bos_util.c
index fbf3411335307ff15923bdf81592f3ae362e1f54..190cd12bb90ff4a9b2e2fd2c10dac88e31082c09 100644 (file)
--- a/src/bozo/bos_util.c
+++ b/src/bozo/bos_util.c
@@ -195,7 +195,7 @@ main(int argc, char **argv)
                printf("kvno %4d: key is '%s' '", tkeys.key[i].kvno, tbuffer);
                strcpy(x,(char *)tbuffer);
                for(count=0;count<8;count++)
-                   printf("\\%03o",(unsigned char *)x[count]);
+                   printf("\\%03o", x[count]);
                printf("'\n");
            }
        }

diff --git a/src/rx/bulktest/Makefile.in b/src/rx/bulktest/Makefile.in
index 7c690d5e29af696cc7f04d791bb5ad8739bd2038..d4f8988bf31f8e76e13de14556f4508b56da1bf6 100644 (file)
--- a/src/rx/bulktest/Makefile.in
+++ b/src/rx/bulktest/Makefile.in
@@ -14,7 +14,7 @@ LIBRX=${SRCDIR}/lib/librx.a
 DESTDIR=/usr/andy/
 INSTALL=${SRCDIR}/bin/install
 LIBS=${LIBRX} ${SRCDIR}/lib/liblwp.a
-CFLAGS=-g -I.. -I. -I${SRCDIR}/include -DDEBUG ${XCFLAGS}
+CFLAGS=${DBG} -I.. -I. -I${SRCDIR}/include -DDEBUG ${XCFLAGS}
 
 all: bulk_client bulk_server
 

diff --git a/src/rx/multi.example/Makefile.in b/src/rx/multi.example/Makefile.in
index 8dd14725b822af34c1dc35777515a93cec362713..cb6eef53f0931b9bf884a493d32e74fadc5cfd5a 100644 (file)
--- a/src/rx/multi.example/Makefile.in
+++ b/src/rx/multi.example/Makefile.in
@@ -14,7 +14,7 @@ LIBRX=${SRCDIR}/lib/librx.a
 DESTDIR=/usr/andy/
 INSTALL=${SRCDIR}/bin/install
 LIBS=${LIBRX} ${SRCDIR}/lib/liblwp.a
-CFLAGS=-g -I.. -I. -I${SRCDIR}/include -DDEBUG ${XCFLAGS}
+CFLAGS=${DBG} -I.. -I. -I${SRCDIR}/include -DDEBUG ${XCFLAGS}
 
 all: sample_client sample_server
 

diff --git a/src/rx/simple.example/Makefile.in b/src/rx/simple.example/Makefile.in
index 191b70a7ee846cd80929c51c8409a4c9f67cfd99..d974c0da80a2ccfde2596f4904e1b8e7484e2c7d 100644 (file)
--- a/src/rx/simple.example/Makefile.in
+++ b/src/rx/simple.example/Makefile.in
@@ -14,7 +14,7 @@ LIBRX=${SRCDIR}/lib/librx.a
 DESTDIR=/usr/andy/
 INSTALL=${SRCDIR}/bin/install
 LIBS=${LIBRX} ${SRCDIR}/lib/liblwp.a
-CFLAGS=-g -I. -I${SRCDIR}/include -DDEBUG ${XCFLAGS}
+CFLAGS=${DBG} -I. -I${SRCDIR}/include -DDEBUG ${XCFLAGS}
 
 all: sample_client sample_server
 

diff --git a/src/sys/rmtsysc.c b/src/sys/rmtsysc.c
index 1e1fcd1075de76312a72411242d1435f45192422..04ae46c8fa56a26b2129c525b67345c8da521156 100644 (file)
--- a/src/sys/rmtsysc.c
+++ b/src/sys/rmtsysc.c
@@ -33,6 +33,9 @@ RCSID("$Header$");
 #ifdef HAVE_STRING_H
 #include <string.h>
 #endif
+#ifdef HAVE_UNISTD_H
+#include <unistd.h>
+#endif
 #include <rx/xdr.h>
 #include "rmtsys.h"
 

diff --git a/src/uss/uss_common.h b/src/uss/uss_common.h
index 782fc1bfc015c6bbf71715ac0c6398c099350b46..f3e40496da12d05987ca29edca09fe13858c5578 100644 (file)
--- a/src/uss/uss_common.h
+++ b/src/uss/uss_common.h
@@ -23,6 +23,13 @@
 #include <stdio.h>             /*I/O stuff*/
 #include <afs/afsutil.h>
 #include <errno.h>
+#ifdef HAVE_STRING_H
+#include <string.h>
+#else
+#ifdef HAVE_STRINGS_H
+#include <strings.h>
+#endif
+#endif
 
 /*
  * --------------------- Exported definitions ---------------------

diff --git a/src/util/potpourri.h b/src/util/potpourri.h
index 3d7bb86853e57db859234acf16de25aab20ab6ea..9849e3ecd6bde5a82e5afd8fa0681869ab41e7c8 100644 (file)
--- a/src/util/potpourri.h
+++ b/src/util/potpourri.h
@@ -92,6 +92,7 @@ Abstract:     Contains miscellaneous general-purpose macros.
        BEWARE:  avoid quotes in the assertion!!
        Also beware: you cannot make the NOASSERT case a null macro, because of side effects */
 
+#undef assert
 #ifndef NOASSERT
 #define assert(ex) {if (!(ex)){fprintf(stderr,"Assertion failed: file %s, line %d\n", __FILE__, __LINE__);fprintf(stderr, "\t%s\n", # ex); abort();}}
 #else

diff --git a/src/util/test/Makefile.in b/src/util/test/Makefile.in
index 10fb7c8aab4e97224c17d31aa5d85e6fed61984d..f99bfd508b3c618ca1ecfc761f03db7e3f2f57fb 100644 (file)
--- a/src/util/test/Makefile.in
+++ b/src/util/test/Makefile.in
@@ -9,7 +9,7 @@ srcdir=@srcdir@
 include @TOP_OBJDIR@/src/config/Makefile.config
 
 
-CFLAGS = -I. -I.. -I${SRCDIR}/include ${XCFLAGS} -g
+CFLAGS = -I. -I.. -I${SRCDIR}/include ${XCFLAGS} ${DBG}
 
 tests: test_ktime ktest dirpath_test
 

diff --git a/src/venus/fs.c b/src/venus/fs.c
index 3fed75dd3bdaa5c1e20df483bd4a92b4efe6e215..18ac2a13b8d269fd343b965acb252049854e35ce 100644 (file)
--- a/src/venus/fs.c
+++ b/src/venus/fs.c
@@ -51,13 +51,6 @@ RCSID("$Header$");
 #include <afs/cmd.h>
 #include <afs/afsutil.h>
 #include <stdlib.h>
-#ifdef HAVE_STRING_H
-#include <string.h>
-#else
-#ifdef HAVE_STRINGS_H
-#include <strings.h>
-#endif
-#endif
 #include <assert.h>
 #include <afs/ptclient.h>
 

diff --git a/src/venus/kdump.c b/src/venus/kdump.c
index f269bbb935df4c3173a37059e5e83c0b634ab0ca..304cb3c123d8ce432c03f6028c71efa26e185002 100644 (file)
--- a/src/venus/kdump.c
+++ b/src/venus/kdump.c
@@ -55,7 +55,7 @@ struct ncp_sb_info{};
 #define u16 unsigned short
 #include <features.h>
 #if __GLIBC_MINOR__ >= 2
-#define _SYS_TYPES_H
+#define _SYS_TYPES_H 1
 #endif
 #define __KERNEL__
 #endif