ptserver: Zero ubik header before writing to it

When using pt_util's ubik shim, if we're creating a new ubik label
make sure to zero the whole structure before writing it out to disk.
Otherwise we get a shorts worth of stack garbage in the resulting
file.

Caught by coverity (#986010)

Change-Id: I0abb8b7968d4f25c97dc0927d63dd01099b829b7
Reviewed-on: http://gerrit.openafs.org/9274
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>

diff --git a/src/ptserver/ptubik.c b/src/ptserver/ptubik.c
index 6ca0eef9e8e99ea509bbf455b5d7f690bede8ab3..f059d2cc7351703d4e661ea673a799dff7bdd153 100644 (file)
--- a/src/ptserver/ptubik.c
+++ b/src/ptserver/ptubik.c
@@ -33,6 +33,7 @@ ubik_BeginTrans(struct ubik_dbase *dbase, afs_int32 transMode,
     struct ubik_hdr thdr;
 
     if (!init) {
+       memset(&thdr, 0, sizeof(thdr));
        thdr.version.epoch = htonl(2);
        thdr.version.counter = htonl(0);
        thdr.magic = htonl(UBIK_MAGIC);