opr: fix often reported warning

$ make CC=cgcc CHECK="smatch -Wsparse-all" 2>&1 | tee debug
$ sed -n 's/.*warning: //p' debug | sort | uniq -c | sort -n | tail -1
   7218 passing argument 1 of 'opr_AssertionFailed' discards 'const' qualifier from pointer target type [enabled by default]

Change-Id: I81c5c1db39b1a08c7dda3caa3d4cdf685186ff5b
Address: http://smatch.sourceforge.net/
Reviewed-on: http://gerrit.openafs.org/10019
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>

diff --git a/src/opr/assert.c b/src/opr/assert.c
index 7c8998f158df5ec18b02472c0ff4036441161a7f..e3d3543b3cdab44490e890707807193017e7bba0 100644 (file)
--- a/src/opr/assert.c
+++ b/src/opr/assert.c
@@ -14,7 +14,7 @@ opr_NTAbort(void)
 
 #define TIMESTAMP_BUFFER_SIZE 26  /* including the null */
 void
-opr_AssertionFailed(char *file, int line)
+opr_AssertionFailed(const char *file, int line)
 {
     char tdate[TIMESTAMP_BUFFER_SIZE];
     time_t when;

diff --git a/src/opr/opr.h b/src/opr/opr.h
index 45e037d7c251dd1290f5c17ab3154c32d5fcb329..b2cd7d6a69ba916595cb1c42ef5a752dd0c7ac27 100644 (file)
--- a/src/opr/opr.h
+++ b/src/opr/opr.h
@@ -16,7 +16,7 @@ extern void opr_NTAbort(void);
 # define opr_abort() abort()
 #endif
 
-extern void opr_AssertionFailed(char *, int) AFS_NORETURN;
+extern void opr_AssertionFailed(const char *, int) AFS_NORETURN;
 extern void opr_AssertFailU(const char *, const char *, int) AFS_NORETURN;
 
 /* opr_Assert is designed to work in a similar way to the operating