dafs: avoid null deref getting volume header

we don't assign hd before dereferencing. stop dereferencing
and just use the queue cursor.

Reviewed-on: http://gerrit.openafs.org/5814
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 00beae8c4e3b390637f20584e676cf86c817dadd)

Change-Id: Iec2dbbf84e4f08f02998c9e998d2ea899ce48a5d
Reviewed-on: http://gerrit.openafs.org/6122
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>

diff --git a/src/vol/volume.c b/src/vol/volume.c
index 64647ade12426176d77d31c92b5f7baac8ece32e..c7cca3f10831e1927558a5fcbabfaf821820e862 100644 (file)
--- a/src/vol/volume.c
+++ b/src/vol/volume.c
@@ -7481,7 +7481,7 @@ GetVolHeaderFromLRU(void)
      * could VWaitExclusiveState_r instead, but not waiting is faster and
      * easier to do */
     for (queue_Scan(&volume_hdr_LRU, qh, nqh, volHeader)) {
-       if (!hd->back || !VIsExclusiveState(V_attachState(hd->back))) {
+       if (!qh->back || !VIsExclusiveState(V_attachState(qh->back))) {
            queue_Remove(qh);
            hd = qh;
            break;