ptserver: Don't ignore ubik_Write failures

If we can't write to the ubik database, then that's a bad thing.
Don't ignore it.

Caught by clang-analyzer

Reviewed-on: http://gerrit.openafs.org/9176
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 860c34ba938602387f78c10c2f548fb8a523a9cd)

Change-Id: Id379d94844e6cc520829b4ef6015d0a004fdbc42
Reviewed-on: http://gerrit.openafs.org/9526
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

diff --git a/src/ptserver/ptutils.c b/src/ptserver/ptutils.c
index d2548dbc96404360280575f5ff312627813fdb78..9d764fcd574b305372477765a3017a4657b92759 100644 (file)
--- a/src/ptserver/ptutils.c
+++ b/src/ptserver/ptutils.c
@@ -457,6 +457,8 @@ CreateEntry(struct ubik_trans *at, char aname[PR_MAXNAMELEN], afs_int32 *aid, af
 
        /* write updated entry for group */
        code = pr_Write(at, 0, pos, &centry, sizeof(centry));
+       if (code)
+           return PRDBFAIL;
 
        /* Now add the new user entry to the database */
        tentry.creator = creator;

diff --git a/src/ptserver/utils.c b/src/ptserver/utils.c
index 230e76041eabc651c48fa72ca3cd44326671a096..822df99486acb61ba4316420a361ed3b0588cb87 100644 (file)
--- a/src/ptserver/utils.c
+++ b/src/ptserver/utils.c
@@ -488,6 +488,8 @@ RemoveFromIDHash(struct ubik_trans *tt, afs_int32 aid, afs_int32 *loc)              /* ??? i
            return PRDBFAIL;
        bentry.nextID = tentry.nextID;
        code = pr_WriteEntry(tt, 0, trail, &bentry);
+       if (code)
+           return PRDBFAIL;
     }
     *loc = current;
     return PRSUCCESS;
@@ -566,6 +568,8 @@ RemoveFromNameHash(struct ubik_trans *tt, char *aname, afs_int32 *loc)
            return PRDBFAIL;
        bentry.nextName = tentry.nextName;
        code = pr_WriteEntry(tt, 0, trail, &bentry);
+       if (code)
+           return PRDBFAIL;
     }
     *loc = current;
     return PRSUCCESS;