]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
libadmin: Remove redundant memset call
authorStephan Wiesand <stephan.wiesand@desy.de>
Fri, 30 May 2014 13:05:28 +0000 (15:05 +0200)
committerStephan Wiesand <stephan.wiesand@desy.de>
Thu, 26 Jun 2014 09:42:14 +0000 (05:42 -0400)
Commit bf78bf2c115659b78c34d3bc9d1934bcff21c8cc added initialisation
of the nbulkentries structure to 0, to avoid freeing garbage due to a
goto fail_... before the structure is initialised. As pointed out by
Andrew Deason, there already is an equivalent memset call later in the
code which is now redundant. Remove it.

Reviewed-on: http://gerrit.openafs.org/11180
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
(cherry picked from commit f05abc47938beddb436fd0b9677f7b59fc64a215)

Change-Id: I7338e42a45d0871af2ad404191ab622605172ac3
Reviewed-on: http://gerrit.openafs.org/11195
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
src/libadmin/vos/afs_vosAdmin.c

index 55978e5fb4b7699134e6e104cc30358e5f787bb0..bed8c494f6ea13e995319c1a0797f59d40295676 100644 (file)
@@ -381,8 +381,6 @@ vos_BackupVolumeCreateMultiple(const void *cellHandle,
        prefix_len = strlen(volumePrefix);
     }
 
-    memset((void *)&arrayEntries, 0, sizeof(arrayEntries));
-
     /*
      * Get a list of all the volumes in the cell
      */