]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
rxgen: avoid an unimportant memory leak in docppline()
authorGarrett Wollman <wollman@csail.mit.edu>
Wed, 25 Jul 2012 04:49:25 +0000 (00:49 -0400)
committerDerrick Brashear <shadow@dementix.org>
Wed, 25 Jul 2012 20:27:24 +0000 (13:27 -0700)
If cpp emitted
  # 1234 ""
docppline() would leak a small buffer.  Just free it.
The static analyzer will thank you.

Change-Id: I34ae6e228469a900139375f2a4758855922cf0ef
Reviewed-on: http://gerrit.openafs.org/7871
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Simon Wilkinson <simonxwilkinson@gmail.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/rxgen/rpc_scan.c

index c406be57433330d02b9ff3bc40564656c8813312..dc3abc051f0ba926b6cb6d2f3263532fde8842e5 100644 (file)
@@ -517,6 +517,7 @@ docppline(char *line, int *lineno, char **fname)
     *p = 0;
     if (*file == 0) {
        *fname = NULL;
+       free(file);
     } else {
        *fname = file;
     }