uninitialized-variable-20040605

 cm_dns.c: getAFSServers() did not initialize the output
           parameters before testing them when setting the
           return value.  It therefore returned success
           when the network was unavailable. Bad Bad Bad.

diff --git a/src/WINNT/afsd/cm_dns.c b/src/WINNT/afsd/cm_dns.c
index 14fa4269b5e45ada4301e9314c2dd308b856a84e..81a3962ba26918776d6fba159da2729307c62dbd 100644 (file)
--- a/src/WINNT/afsd/cm_dns.c
+++ b/src/WINNT/afsd/cm_dns.c
@@ -698,14 +698,14 @@ int getAFSServer(char *cellName, int *cellHostAddrs, char cellHostNames[][MAXHOS
        DWORD i;
     struct sockaddr_in vlSockAddr;
 
+    *numServers = 0; 
+    *ttl = 0;
+
     /* query the AFSDB records of cell */
        if (DnsQuery_A(cellName, DNS_TYPE_AFSDB, DNS_QUERY_STANDARD, NULL, &pDnsCell, NULL) == ERROR_SUCCESS) {
 
                memset((void*) &vlSockAddr, 0, sizeof(vlSockAddr));
                
-               *numServers = 0; 
-        *ttl = 0;
-
                /* go through the returned records */
                for (pDnsIter = pDnsCell;pDnsIter; pDnsIter = pDnsIter->pNext) {
                        /* if we find an AFSDB record with Preference set to 1, we found a volserver */