disconnected-dont-double-dequeue-shadow-removal-20090323

LICENSE IPL10
FIXES 124496

queue_Remove twice tends to cause things like panics

diff --git a/src/afs/afs_disconnected.c b/src/afs/afs_disconnected.c
index 68486c593ece6c99180caffb70ab93ba07da3b48..716dfadfd4c9dac2b6e49d2b737b96070cdf476d 100644 (file)
--- a/src/afs/afs_disconnected.c
+++ b/src/afs/afs_disconnected.c
@@ -1317,10 +1317,8 @@ afs_DisconDiscardAllShadows(int squash, struct AFS_UCRED *acred) {
        if (squash)
           afs_ResetVCache(tvc, acred);
 
-       ObtainWriteLock(&afs_disconDirtyLock, 709);
-       QRemove(&tvc->shadowq);
-
        ReleaseWriteLock(&tvc->lock);
+       ObtainWriteLock(&afs_disconDirtyLock, 709);
     }                          /* while (tvc) */
 }