cacheout: Use authenticated secClass for VLDB

Currently 'cacheout' will always utilize an unauthenticated connection
when talking to the VDLB, even if it uses an authenticated connection
when talking to fileservers. This is regardless of any tokens
retrieved or command-line parameters, etc.

Using an authenticated connection to the VLDB can be useful, since a
user may want to encrypt the VLDB communication, or require stronger
guarantees of data consistency. So, just use the same security class
information for our VLDB communication as for our fileserver
communication.

'scnull' is now not used anywhere after this commit, so get rid of it.

Change-Id: I1e8a440ea7427399a3b219246e4c3623a603c35e
Reviewed-on: http://gerrit.openafs.org/11637
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Daria Brashear <shadow@your-file-system.com>

diff --git a/src/venus/cacheout.c b/src/venus/cacheout.c
index 33f186145333f9d1b58f8f7bdccd4f967e82aac8..f7b1d5a2c16bc686742324b4b606902778fe1bb5 100644 (file)
--- a/src/venus/cacheout.c
+++ b/src/venus/cacheout.c
@@ -239,7 +239,6 @@ MyBeforeProc(struct cmd_syndesc *as, void *arock)
     struct afsconf_cell info;
     struct rx_connection *serverconns[MAXSERVERS];
     afs_int32 code, i;
-    struct rx_securityClass *scnull;
     rxkad_level sclevel = rxkad_auth;
 
     sprintf(confdir, "%s", AFSDIR_CLIENT_ETC_DIRPATH);
@@ -258,7 +257,7 @@ MyBeforeProc(struct cmd_syndesc *as, void *arock)
        return 1;
     }
 
-    scnull = sc = rxnull_NewClientSecurityObject();
+    sc = rxnull_NewClientSecurityObject();
     scindex = 0;
 
     tdir = afsconf_Open(confdir);
@@ -310,8 +309,8 @@ MyBeforeProc(struct cmd_syndesc *as, void *arock)
     for (i = 0; i < info.numServers; ++i)
        serverconns[i] =
            rx_NewConnection(info.hostAddr[i].sin_addr.s_addr,
-                            info.hostAddr[i].sin_port, USER_SERVICE_ID, scnull,
-                            0);
+                            info.hostAddr[i].sin_port, USER_SERVICE_ID, sc,
+                            scindex);
     for (; i < MAXSERVERS; ++i) {
        serverconns[i] = (struct rx_connection *)0;
     }