namei-delay-fsync-20060426

FIXES 30632

group fsync calls to speed up operations

diff --git a/src/vol/clone.c b/src/vol/clone.c
index 1a02d2d266b683a3a42dbb4216cbfd976aa0cf30..df4a0f176e59218d7a6ad2bb03750bf2891bcefa 100644 (file)
--- a/src/vol/clone.c
+++ b/src/vol/clone.c
@@ -227,6 +227,12 @@ DoCloneIndex(Volume * rwvp, Volume * clvp, VnodeClass class, int reclone)
     decRock.vol = V_parentId(rwvp);
 
     /* Read each vnode in the old volume's index file */
+    /* fsyncing the link count file for every inode has a severe 
+       performance penalty, therefore we turn it off temporarily.
+       This assumes we're the only one on that file/volume  -
+       in particular when we force the fsync later!
+    */
+    V_linkHandle(rwvp)->ih_flags|=IH_DELAY_SYNC;
     for (offset = vcp->diskSize;
         STREAM_READ(rwvnode, vcp->diskSize, 1, rwfile) == 1;
         offset += vcp->diskSize) {
@@ -345,6 +351,12 @@ DoCloneIndex(Volume * rwvp, Volume * clvp, VnodeClass class, int reclone)
      * and shouldn't do the idecs.
      */
   error_exit:
+    /* Now take the fsync-bypass away again and force an fsync.
+       Again: assumes we're alone on this file, otherwise we need a lock!
+    */
+    V_linkHandle(rwvp)->ih_flags&=~IH_DELAY_SYNC;
+    IH_CONDSYNC(V_linkHandle(rwvp));
+
     if (rwfile)
        STREAM_CLOSE(rwfile);
     if (clfilein)

diff --git a/src/vol/ihandle.h b/src/vol/ihandle.h
index 2aee89da524246823225610907a142f331ca9255..38d9ab30bcd69ceb843a0b74510d7ce41eda9820 100644 (file)
--- a/src/vol/ihandle.h
+++ b/src/vol/ihandle.h
@@ -221,6 +221,7 @@ typedef struct IHandle_s {
 
 /* Flags for the Inode handle */
 #define IH_REALLY_CLOSED               1
+#define IH_DELAY_SYNC                  16
 
 /* Hash function for inode handles */
 #define I_HANDLE_HASH_SIZE     1024    /* power of 2 */
@@ -466,7 +467,7 @@ extern afs_sfsize_t ih_size(int fd);
 #define FDH_WRITE(H, B, S) OS_WRITE((H)->fd_fd, B, S)
 #define FDH_SEEK(H, O, F) OS_SEEK((H)->fd_fd, O, F)
 
-#define FDH_SYNC(H) OS_SYNC((H)->fd_fd)
+#define FDH_SYNC(H) ((H->fd_ih->ih_flags&IH_DELAY_SYNC) ? 0 : OS_SYNC((H)->fd_fd))
 #define FDH_TRUNC(H, L) OS_TRUNC((H)->fd_fd, L)
 #define FDH_SIZE(H) OS_SIZE((H)->fd_fd)
 

diff --git a/src/vol/namei_ops.c b/src/vol/namei_ops.c
index 910b1d04e22bed67e75ae383fd60d6223dfc7433..3bd3fd7d2e50c205cafc95149095044995d4c825 100644 (file)
--- a/src/vol/namei_ops.c
+++ b/src/vol/namei_ops.c
@@ -572,6 +572,8 @@ namei_icreate(IHandle_t * lh, char *part, int p1, int p2, int p3, int p4)
 
     if (p2 == -1 && p3 == VI_LINKTABLE) {
        /* hack at tmp to setup for set link count call. */
+       memset((void *)&tfd, 0, sizeof(FdHandle_t));    /* minimalistic still, but a little cleaner */
+       tfd.fd_ih = &tmp;
        tfd.fd_fd = fd;
        code = namei_SetLinkCount(&tfd, (Inode) 0, 1, 0);
     }

diff --git a/src/vol/purge.c b/src/vol/purge.c
index 4b13fcf2bc456a9ff066f524126660d112f27a44..dd94a27ece0d4b880273ba78db5d47adf0f64a72 100644 (file)
--- a/src/vol/purge.c
+++ b/src/vol/purge.c
@@ -94,7 +94,7 @@ VPurgeVolume(Error * ec, Volume * vp)
     VOL_UNLOCK;
 }
 
-#define MAXOBLITATONCE 200
+#define MAXOBLITATONCE 1000
 /* delete a portion of an index, adjusting offset appropriately.  Returns 0 if
    things work and we should be called again, 1 if success full and done, and -1
    if an error occurred.  It adjusts offset appropriately on 0 or 1 return codes,
@@ -153,10 +153,13 @@ ObliterateRegion(Volume * avp, VnodeClass aclass, StreamHandle_t * afile,
     OS_SYNC(afile->str_fd);
 
     /* finally, do the idec's */
+    V_linkHandle(avp)->ih_flags|=IH_DELAY_SYNC;                /* severe performance penalty */
     for (i = 0; i < iindex; i++) {
        IH_DEC(V_linkHandle(avp), inodes[i], V_parentId(avp));
        DOPOLL;
     }
+    V_linkHandle(avp)->ih_flags&=~IH_DELAY_SYNC;
+    IH_CONDSYNC(V_linkHandle(avp));
 
     /* return the new offset */
     *aoffset = offset;

diff --git a/src/volser/dumpstuff.c b/src/volser/dumpstuff.c
index 73765d028137293c83de6247018c4bfffd076049..9276a97e3bfcdf1457dabcd75284c9a9917f122a 100644 (file)
--- a/src/volser/dumpstuff.c
+++ b/src/volser/dumpstuff.c
@@ -1058,7 +1058,13 @@ RestoreVolume(register struct rx_call *call, Volume * avp, int incremental,
 
     tdelo = delo;
     while (1) {
-       if (ReadVnodes(iodp, vp, 0, b1, s1, b2, s2, tdelo)) {
+       int temprc;
+
+       V_linkHandle(avp)->ih_flags |= IH_DELAY_SYNC;   /* Avoid repetitive fdsync()s on linkfile */
+       temprc = ReadVnodes(iodp, vp, 0, b1, s1, b2, s2, tdelo);
+       V_linkHandle(avp)->ih_flags &= ~IH_DELAY_SYNC;  /* normal sync behaviour again */
+       IH_CONDSYNC(V_linkHandle(avp));                 /* sync link file */
+       if (temprc) {
            error = VOLSERREAD_DUMPERROR;
            goto clean;
        }