pam: Tidy header includes

Remove headers which are provided by libroken, and reorder header
includes so that they're a bit a more legible.

Change-Id: I9a8c2d588eb00d1315c660faa485037cef2f8e6d
Reviewed-on: http://gerrit.openafs.org/4401
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>

diff --git a/src/pam/afs_account.c b/src/pam/afs_account.c
index 173aad4efc980cc1a1719153467a8e21ff09c5ff..249e3434434e1ea2390fa6d77aa85f4af9f3076d 100644 (file)
--- a/src/pam/afs_account.c
+++ b/src/pam/afs_account.c
@@ -10,7 +10,6 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
 #include <security/pam_appl.h>
 #include <security/pam_modules.h>
 

diff --git a/src/pam/afs_auth.c b/src/pam/afs_auth.c
index 9cf3a89b6d3f880883fa59e5fd1a6eb167aada2c..09f52148eb33fec424f34b1001368a491a9f9e94 100644 (file)
--- a/src/pam/afs_auth.c
+++ b/src/pam/afs_auth.c
@@ -10,17 +10,13 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#include <syslog.h>
-#include <stdlib.h>
-#include <string.h>
-#include <pwd.h>
-#include <unistd.h>
-#include <sys/param.h>
+#ifdef HAVE_SYS_WAIT_H
 #include <sys/wait.h>
+#endif
+
 #include <afs/kautils.h>
-#include <signal.h>
-#include <errno.h>
 
 #include <security/pam_appl.h>
 #include <security/pam_modules.h>

diff --git a/src/pam/afs_message.c b/src/pam/afs_message.c
index 51cf826d02e8ad343b031f9181d97a2f1e1ac380..647a7a16d33264716f8ee116f98056347c442882 100644 (file)
--- a/src/pam/afs_message.c
+++ b/src/pam/afs_message.c
@@ -7,22 +7,16 @@
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
-#include <syslog.h>
-#include <stdlib.h>
-#include <string.h>
-#include <pwd.h>
-#include <unistd.h>
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
 #include <security/pam_appl.h>
 #include <security/pam_modules.h>
 
-
-#include <sys/param.h>
 #include <afs/kautils.h>
-#include <stdarg.h>
+
 #include "afs_message.h"
 #include "afs_util.h"
 

diff --git a/src/pam/afs_pam_msg.c b/src/pam/afs_pam_msg.c
index e55461283713e171b6229493bb2bb6dd0d94999e..bcbbc135a7834fed99579f1729c07633dbdac86a 100644 (file)
--- a/src/pam/afs_pam_msg.c
+++ b/src/pam/afs_pam_msg.c
@@ -10,14 +10,12 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#include <stdio.h>
-#include <string.h>
-#include <stdlib.h>
 #include <security/pam_appl.h>
+
 #include "afs_pam_msg.h"
 #include "afs_message.h"
-#include <stdarg.h>
 
 
 int

diff --git a/src/pam/afs_password.c b/src/pam/afs_password.c
index 3bd471ab44224fdc4f4d7fc7b111928d452e2c75..a818772712097e6c2179e858b5ee9f1c48717043 100644 (file)
--- a/src/pam/afs_password.c
+++ b/src/pam/afs_password.c
@@ -7,26 +7,22 @@
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
-#include <syslog.h>
-#include <stdlib.h>
-#include <string.h>
-#include <pwd.h>
-#include <unistd.h>
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
+
+#ifdef HAVE_SYS_WAIT_H
+#include <sys/wait.h>
+#endif
+
 #include <security/pam_appl.h>
 #include <security/pam_modules.h>
 
-
-#include <sys/param.h>
 #include <afs/kautils.h>
 #include "afs_message.h"
 #include "afs_util.h"
 #include "afs_pam_msg.h"
-#include <signal.h>
-#include <sys/wait.h>
-#include <errno.h>
 
 #define RET(x) { retcode = (x); goto out; }
 

diff --git a/src/pam/afs_session.c b/src/pam/afs_session.c
index 788e8616085f6cdb9e106aa9c3529e39380cbfbe..2de18f8c3fbcb525042a9e16baccbc399bfc17b3 100644 (file)
--- a/src/pam/afs_session.c
+++ b/src/pam/afs_session.c
@@ -10,12 +10,7 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
-
-#include <syslog.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-#include <errno.h>
+#include <roken.h>
 
 #include <security/pam_appl.h>
 #include <security/pam_modules.h>

diff --git a/src/pam/afs_setcred.c b/src/pam/afs_setcred.c
index e671f24ed9343f6bc07f88e3da3c373b72fff8c0..e3a83495eca686d4372ebfb3e735c205cbfbc612 100644 (file)
--- a/src/pam/afs_setcred.c
+++ b/src/pam/afs_setcred.c
@@ -7,21 +7,16 @@
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
-#include <syslog.h>
-#include <stdlib.h>
-#include <string.h>
-#include <pwd.h>
-#include <unistd.h>
-#include <errno.h>
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
+
 #include <security/pam_appl.h>
 #include <security/pam_modules.h>
 
-
-#include <sys/param.h>
 #include <afs/kautils.h>
+
 #include "afs_message.h"
 #include "afs_util.h"
 

diff --git a/src/pam/afs_util.c b/src/pam/afs_util.c
index c9d1a6f491f4ffc9d2a2e5ef515484d2e5903988..d127926723f91b5f1027139f1ee9cef704ed54f5 100644 (file)
--- a/src/pam/afs_util.c
+++ b/src/pam/afs_util.c
@@ -7,18 +7,18 @@
  * directory or online at http://www.openafs.org/dl/license10.html
  */
 
-#include <stdio.h>
-#include <assert.h>
-#include <unistd.h>
-#include <errno.h>
-#include <syslog.h>
-#include <security/pam_appl.h>
 #include <afsconfig.h>
 #include <afs/param.h>
+
+#include <roken.h>
+
+#ifdef HAVE_SYS_WAIT_H
 #include <sys/wait.h>
+#endif
+
+#include <assert.h>
 #include <limits.h>
-#include <string.h>
-#include <stdlib.h>
+
 #ifdef AFS_AIX51_ENV
 #include <sys/cred.h>
 #ifdef HAVE_SYS_PAG_H
@@ -26,6 +26,7 @@
 #endif
 #endif
 
+#include <security/pam_appl.h>
 
 #include "afs_util.h"
 
@@ -50,29 +51,6 @@ nil_cleanup(pam_handle_t * pamh, void *data, int pam_end_status)
     return;
 }
 
-/* The PAM module needs to be free from libucb dependency. Otherwise,
-dynamic linking is a problem, the AFS PAM library refuses to coexist
-with the DCE library. The sigvec() and sigsetmask() are the only two
-calls that neccesiate the inclusion of libucb.a.  There are used by
-the lwp library to support premeptive threads and signalling between
-threads. Since the lwp support used by the PAM module uses none of
-these facilities, we can safely define these to be null functions */
-
-#if !defined(AFS_HPUX110_ENV)
-/* For HP 11.0, this function is in util/hputil.c */
-int
-sigvec(int sig, const struct sigvec *vec, struct sigvec *ovec)
-{
-    assert(0);
-}
-
-int
-sigsetmask(int mask)
-{
-    assert(0);
-}
-#endif /* AFS_HPUX110_ENV */
-
 /* converts string to integer */
 
 char *

diff --git a/src/pam/test_pam.c b/src/pam/test_pam.c
index 6ba4b1437633bba0e18f3dcbfcfadab5df451a84..0665a3c585d7e4b812bd22981ea1a4f900e210c7 100644 (file)
--- a/src/pam/test_pam.c
+++ b/src/pam/test_pam.c
@@ -10,13 +10,9 @@
 #include <afsconfig.h>
 #include <afs/param.h>
 
+#include <roken.h>
 
-#include <stdio.h>
 #include <security/pam_appl.h>
-#include <string.h>
-#include <stdlib.h>
-#include <unistd.h>
-
 
 static int my_conv(int num_msg, PAM_CONST struct pam_message **msg,
                   struct pam_response **response, void *appdata_ptr);