namei-close-directory-behind-us-always-20020827

more or less verbatim as suggested by kolya@mit.edu

avoid leaking directory fds if we get an error

diff --git a/src/vol/namei_ops.c b/src/vol/namei_ops.c
index e1cb1f63d93387996258300ac89a3276260e3b8d..df6371e6e2a8b1f3699bfe1d5c783d287f08bf4d 100644 (file)
--- a/src/vol/namei_ops.c
+++ b/src/vol/namei_ops.c
@@ -317,8 +317,8 @@ delTree(char *root, char *tree, int *errp)
         */
        *cp = 0; 
       }
-      if (!errno)
-       closedir(ds);
+      /* if (!errno) -- closedir not implicit if we got an error */
+      closedir(ds);
     } 
     
     /* finally axe the current dir */