]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
vol: Don't always FDH_REALLYCLOSE on linktable ops
authorAndrew Deason <adeason@sinenomine.net>
Fri, 1 Jul 2011 21:58:06 +0000 (16:58 -0500)
committerDerrick Brashear <shadow@dementia.org>
Sat, 9 Jul 2011 05:08:40 +0000 (22:08 -0700)
If we dec a linktable entry or get a free tag from the link table,
there is no reason to FDH_REALLYCLOSE the linktable fd handle.
FDH_REALLYCLOSE is the same as FDH_CLOSE, except that it tells the
ihandle package that the file handle will not be used again soon. If
we dec a linktable entry or get a free tag, there is no reason to
think that, so just FDH_CLOSE the handle instead.

Reviewed-on: http://gerrit.openafs.org/4903
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit 78e39417af6d2b87f0cbda0b5d3bb3e4859dc0ba)

Change-Id: I28f5abee59265403362f3f1472a9fa21a52597c0
Reviewed-on: http://gerrit.openafs.org/4949
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
src/vol/namei_ops.c

index 659577612156cb759d82dc1e39d368c6f5f74687..59267d0ab914e594fd51da5f59d32d9ccc1c69b9 100644 (file)
@@ -1052,7 +1052,7 @@ namei_dec(IHandle_t * ih, Inode ino, int p1)
            }
 
            if (count > 0) {
-               FDH_REALLYCLOSE(fdP);
+               FDH_CLOSE(fdP);
                IH_RELEASE(tmp);
                return 0;
            }
@@ -1527,7 +1527,7 @@ GetFreeTag(IHandle_t * ih, int vno)
     }
     FDH_SYNC(fdP);
     FDH_UNLOCKFILE(fdP, offset);
-    FDH_REALLYCLOSE(fdP);
+    FDH_CLOSE(fdP);
     return col;
 
   badGetFreeTag: