windows-scache-refcount-race-20080207

LICENSE MIT

if we are going to call a NoLock function better be holding the lock

diff --git a/src/WINNT/afsd/cm_callback.c b/src/WINNT/afsd/cm_callback.c
index 4cea28cabef246c0a9e1dc53ad6e04a6292e3e5d..6c4b447d7e28aacc2953ec362ba565b9a719b597 100644 (file)
--- a/src/WINNT/afsd/cm_callback.c
+++ b/src/WINNT/afsd/cm_callback.c
@@ -1928,8 +1928,8 @@ void cm_CheckCBExpiration(void)
                 lock_ReleaseMutex(&scp->mx);
                 cm_CallbackNotifyChange(scp);
 
-                cm_ReleaseSCacheNoLock(scp);
                 lock_ObtainWrite(&cm_scacheLock);
+                cm_ReleaseSCacheNoLock(scp);
             }
         }
     }