]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
rx: rxi_ReceiveDataPacket do not set rprev on drop
authorJeffrey Altman <jaltman@your-file-system.com>
Mon, 16 Jul 2012 20:53:32 +0000 (16:53 -0400)
committerJeffrey Altman <jaltman@your-file-system.com>
Sat, 21 Jul 2012 23:37:35 +0000 (16:37 -0700)
In KERNEL builds if there are no available packet buffers the
new packet is dropped on the floor.  In that case, the call's
rprev field should not be updated because the packet was never
"received" for delivery to the application.

Remove a dead comment from the same block of code.

Change-Id: I12a2b1618a430880d18efee48e6348e6f9ba8119
Reviewed-on: http://gerrit.openafs.org/7784
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/rx/rx.c

index 8691f96618e3622398971f6eaa41e885eecfc361..0fdeb5a22729fcada5b698aebc68f26b9f3fd90d 100644 (file)
@@ -3851,15 +3851,12 @@ rxi_ReceiveDataPacket(struct rx_call *call,
        MUTEX_EXIT(&rx_freePktQ_lock);
         if (rx_stats_active)
             rx_atomic_inc(&rx_stats.noPacketBuffersOnRead);
-       call->rprev = np->header.serial;
        rxi_calltrace(RX_TRACE_DROP, call);
        dpf(("packet %"AFS_PTR_FMT" dropped on receipt - quota problems\n", np));
         /* We used to clear the receive queue here, in an attempt to free
          * packets. However this is unsafe if the queue has received a
          * soft ACK for the final packet */
        rxi_PostDelayedAckEvent(call, &rx_softAckDelay);
-
-       /* we've damaged this call already, might as well do it in. */
        return np;
     }
 #endif /* KERNEL */