Include suggestions of Rob Browning:

- don't use set -e in testcase
- catch exceptions on read
- reword option-help

Signed-off-by: Tim Riemenschneider <git@tim-riemenschneider.de>

diff --git a/cmd/index-cmd.py b/cmd/index-cmd.py
index 3309398ed19ed7908eb91ce4c5eae4660e4caf66..2e973153fa82048885a8ea393df6497e798aacbc 100755 (executable)
--- a/cmd/index-cmd.py
+++ b/cmd/index-cmd.py
@@ -206,7 +206,7 @@ exclude= a path to exclude from the backup (may be repeated)
 exclude-from= skip --exclude paths in file (may be repeated)
 exclude-rx= skip paths matching the unanchored regex (may be repeated)
 exclude-rx-from= skip --exclude-rx patterns in file (may be repeated)
-exclude-caches exclude CACHEDIR.TAG-directories
+exclude-caches exclude directories containing a CACHEDIR.TAG
 v,verbose  increase log output (can be used more than once)
 x,xdev,one-file-system  don't cross filesystem boundaries
 """

diff --git a/lib/bup/drecurse.py b/lib/bup/drecurse.py
index 4f404150f25c74b55858c125a77f7e9baa583568..4f30ce6a5db6adcef7e8868efe82b13d7abb8ad9 100644 (file)
--- a/lib/bup/drecurse.py
+++ b/lib/bup/drecurse.py
@@ -67,8 +67,10 @@ def _recursive_dirlist(prepend, xdev, bup_dir=None,
                 tag_contents = 'Signature: 8a477f597d28d172789f06886806bc55'
                 if os.path.exists(prepend+name+tag_filename):
                     f = open(prepend+name+tag_filename, 'rb')
-                    data = f.read(len(tag_contents))
-                    f.close()
+                    try:
+                        data = f.read(len(tag_contents))
+                    finally:
+                        f.close()
                     if data == tag_contents:
                         debug1('Skipping %r: excluding cache dir' % (prepend+name))
                         continue

diff --git a/t/test-index-excludes.sh b/t/test-index-excludes.sh
index 86e5bc85e21462e44e4ab03576d82fa5e81bebfd..eea0d13694ec5620c86ebdb186cdd6f8d96de53e 100755 (executable)
--- a/t/test-index-excludes.sh
+++ b/t/test-index-excludes.sh
@@ -7,19 +7,18 @@ bup() { "$top/bup" "$@"; }
 
 WVSTART "exclude-caches"
 (
-    set -e -o pipefail
-    D="$(wvmktempdir)"
-    force-delete $D
-    mkdir $D
+    D="$(WVPASS wvmktempdir)" || exit $?
+    WVPASS force-delete $D
+    WVPASS mkdir $D
     export BUP_DIR="$D/.bup"
     WVPASS bup init
-    touch $D/a
+    WVPASS touch $D/a
     WVPASS bup random 128k >$D/b
-    mkdir $D/d $D/d/e
+    WVPASS mkdir $D/d $D/d/e
     WVPASS bup random 512 >$D/f
-    echo 'Signature: 8a477f597d28d172789f06886806bc55' > $D/d/CACHEDIR.TAG
+    WVPASS echo 'Signature: 8a477f597d28d172789f06886806bc55' > $D/d/CACHEDIR.TAG
     WVPASS bup index -ux --exclude-caches $D
-    bup save -n exclude $D
+    WVPASS bup save -n exclude $D
     WVPASSEQ "$(bup ls exclude/latest/$TOP/$D/)" "a
 b
 f"