FBSD: warning cleanups

Only declare 'p' if it will be used; other unused variables;
signedness mismatches.

Kill spl with fire.

Reviewed-on: http://gerrit.openafs.org/3200
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit ebd18bfade80bd66422aad4310375ee460cd1ed5)

Change-Id: Iac808cf603043a8996f1c8657765ef8a0a7e6d88
Change-Id: I163a4314a0598eec9a514bbc564d8dc2ff91acae
Reviewed-on: http://gerrit.openafs.org/3458
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>

diff --git a/src/afs/FBSD/osi_file.c b/src/afs/FBSD/osi_file.c
index ecd5837afd16f538c967e9ac2a1bad0827b1235c..02fe2536fa8a56d1ac98d9427386c3dd23459d18 100644 (file)
--- a/src/afs/FBSD/osi_file.c
+++ b/src/afs/FBSD/osi_file.c
@@ -158,7 +158,7 @@ int
 afs_osi_Read(struct osi_file *afile, int offset, void *aptr,
             afs_int32 asize)
 {
-    unsigned int resid;
+    int resid;
     afs_int32 code;
     AFS_STATCNT(osi_Read);
 

diff --git a/src/afs/FBSD/osi_machdep.h b/src/afs/FBSD/osi_machdep.h
index 5bc44545ca61a18c1829da74bc5fe83cf8a7d194..6b98f889bdbafed96263c89822258c06d0cf4687 100644 (file)
--- a/src/afs/FBSD/osi_machdep.h
+++ b/src/afs/FBSD/osi_machdep.h
@@ -144,11 +144,11 @@ extern struct thread *afs_global_owner;
 # endif
 
 #undef SPLVAR
-#define SPLVAR int splvar
+#define SPLVAR
 #undef NETPRI
-#define NETPRI splvar=splnet()
+#define NETPRI
 #undef USERPRI
-#define USERPRI splx(splvar)
+#define USERPRI
 
 #define osi_procname(procname, size) strncpy(procname, curproc->p_comm, size)
 

diff --git a/src/afs/FBSD/osi_vcache.c b/src/afs/FBSD/osi_vcache.c
index d00ba68b4a6cf86854dd48ca2275c893da006dd5..6530bb04ed8d03c084c2bbd7816010ee92dd9af5 100644 (file)
--- a/src/afs/FBSD/osi_vcache.c
+++ b/src/afs/FBSD/osi_vcache.c
@@ -15,7 +15,6 @@
 
 int
 osi_TryEvictVCache(struct vcache *avc, int *slept) {
-    struct vnode *vp = AFSTOV(avc);
 
     /*
      * essentially all we want to do here is check that the

diff --git a/src/afs/FBSD/osi_vm.c b/src/afs/FBSD/osi_vm.c
index 571fb67c10cc63f8ca0433178e61c8b7309e0922..438ec92f966ae8f3d7b0d6443e061b5688bd31c4 100644 (file)
--- a/src/afs/FBSD/osi_vm.c
+++ b/src/afs/FBSD/osi_vm.c
@@ -80,7 +80,6 @@
 int
 osi_VM_FlushVCache(struct vcache *avc, int *slept)
 {
-    struct vm_object *obj;
     struct vnode *vp = AFSTOV(avc);
 
     if (!VI_TRYLOCK(vp)) /* need interlock to check usecount */
@@ -186,14 +185,11 @@ osi_VM_TryToSmush(struct vcache *avc, afs_ucred_t *acred, int sync)
     int tries, code;
     int islocked;
 
-    SPLVAR;
-
     vp = AFSTOV(avc);
 
     VI_LOCK(vp);
     if (vp->v_iflag & VI_DOOMED) {
        VI_UNLOCK(vp);
-       USERPRI;
        return;
     }
     VI_UNLOCK(vp);
@@ -238,7 +234,6 @@ osi_VM_TryToSmush(struct vcache *avc, afs_ucred_t *acred, int sync)
        vn_lock(vp, LK_DOWNGRADE);
     else if (!islocked)
        VOP_UNLOCK(vp, 0);
-    USERPRI;
 }
 
 /* Purge VM for a file when its callback is revoked.

diff --git a/src/afs/FBSD/osi_vnodeops.c b/src/afs/FBSD/osi_vnodeops.c
index 5bb5f658d202f6bb61b712aa36b5ade18811b1c1..234668ac47a597079f2c4bc58502514e24daaa1d 100644 (file)
--- a/src/afs/FBSD/osi_vnodeops.c
+++ b/src/afs/FBSD/osi_vnodeops.c
@@ -481,7 +481,9 @@ afs_vop_lookup(ap)
     int flags = ap->a_cnp->cn_flags;
     int lockparent;            /* 1 => lockparent flag is set */
     int wantparent;            /* 1 => wantparent or lockparent flag */
+#ifndef AFS_FBSD80_ENV
     struct thread *p = ap->a_cnp->cn_thread;
+#endif
 
     dvp = ap->a_dvp;
     if (dvp->v_type != VDIR) {
@@ -573,7 +575,9 @@ afs_vop_create(ap)
     int error = 0;
     struct vcache *vcp;
     struct vnode *dvp = ap->a_dvp;
+#ifndef AFS_FBSD80_ENV
     struct thread *p = ap->a_cnp->cn_thread;
+#endif
     GETNAME();
 
     AFS_GLOCK();
@@ -1151,7 +1155,9 @@ afs_vop_link(ap)
     int error = 0;
     struct vnode *dvp = ap->a_tdvp;
     struct vnode *vp = ap->a_vp;
+#ifndef AFS_FBSD80_ENV
     struct thread *p = ap->a_cnp->cn_thread;
+#endif
 
     GETNAME();
     if (dvp->v_mount != vp->v_mount) {
@@ -1195,7 +1201,9 @@ afs_vop_rename(ap)
     struct vnode *tdvp = ap->a_tdvp;
     struct vnode *fvp = ap->a_fvp;
     struct vnode *fdvp = ap->a_fdvp;
+#ifndef AFS_FBSD80_ENV
     struct thread *p = fcnp->cn_thread;
+#endif
 
     /*
      * Check for cross-device rename.
@@ -1297,7 +1305,9 @@ afs_vop_mkdir(ap)
     struct vattr *vap = ap->a_vap;
     int error = 0;
     struct vcache *vcp;
+#ifndef AFS_FBSD80_ENV
     struct thread *p = ap->a_cnp->cn_thread;
+#endif
 
     GETNAME();
 #ifdef DIAGNOSTIC

diff --git a/src/rx/FBSD/rx_knet.c b/src/rx/FBSD/rx_knet.c
index 8072ba8389242a485e6ee26734415bcfc768c7a0..5b7863f24f7ca02f6fe40d21f3d4ef8373d0e385 100644 (file)
--- a/src/rx/FBSD/rx_knet.c
+++ b/src/rx/FBSD/rx_knet.c
@@ -88,11 +88,13 @@ osi_StopListener(void)
        AFS_GUNLOCK();
     soshutdown(rx_socket, SHUT_RDWR);
     p = pfind(rxk_ListenerPid);
-    afs_warn("osi_StopListener: rxk_ListenerPid %lx\n", p);
     if (p) {
+       afs_warn("osi_StopListener: rxk_ListenerPid %u\n", rxk_ListenerPid);
        psignal(p, SIGUSR1);
        PROC_UNLOCK(p);
-    }
+    } else
+       afs_warn("osi_StopListener: rxk_Listener not found (pid %u)\n",
+           rxk_ListenerPid);
 #ifdef AFS_FBSD70_ENV
     {
       /* Avoid destroying socket until osi_NetReceive has