vlserver: unsigned values are always >0

Maxvolidbump is defined as an unisgned int, and thus can never be less
than 0. Remove the pointless check, as it just makes clang sad.

Reviewed-on: http://gerrit.openafs.org/7084
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 350b5d58779cc127b96497283c2d982e099b911c)

Change-Id: Ib902a5b165219469db5f370ebea4c078f10726ee
Reviewed-on: http://gerrit.openafs.org/10740
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

diff --git a/src/vlserver/vlprocs.c b/src/vlserver/vlprocs.c
index 22d0687db8975e7f9b10a6b0b64a9df6413f2087..169bbddee93f07c31008e6a6f6da50c82c01df7d 100644 (file)
--- a/src/vlserver/vlprocs.c
+++ b/src/vlserver/vlprocs.c
@@ -593,7 +593,7 @@ SVL_GetNewVolumeId(struct rx_call *rxcall, afs_uint32 Maxvolidbump,
     if (!afsconf_SuperUser(vldb_confdir, rxcall, NULL))
        END(VL_PERM);
 
-    if (Maxvolidbump < 0 || Maxvolidbump > MAXBUMPCOUNT)
+    if (Maxvolidbump > MAXBUMPCOUNT)
        END(VL_BADVOLIDBUMP);
 
     if ((errorcode = Init_VLdbase(&ctx, LOCKWRITE, this_op)))