]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
DAFS: listvol + unsalvagable volumes = intolerable delay
authorDerrick Brashear <shadow@dementia.org>
Thu, 23 Dec 2010 18:20:42 +0000 (13:20 -0500)
committerDerrick Brashear <shadow@dementix.org>
Thu, 15 Dec 2011 04:19:04 +0000 (20:19 -0800)
a non- inService volume (or more) plus vos listvol equals pain.
return Salvaging instead of waiting for it in the listvol case.

Reviewed-on: http://gerrit.openafs.org/3588
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>
(cherry picked from commit affc978be7ba3c36c9b7a6a94fb5e907beebed99)

Change-Id: If871ce0cdd3593250f22d74de184f92b046b5f6e
Reviewed-on: http://gerrit.openafs.org/6270
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/volser/volprocs.c

index b86501fed944d0e98a2b81e596f9d3cc4353a4c4..5f4f4937ffcf379d4a0a32a2640fbd10f47fcedd 100644 (file)
@@ -2185,7 +2185,10 @@ GetVolInfo(afs_uint32 partId,
     }
 
     /* Get volume from volserver */
-    tv = VAttachVolumeByName_retry(&error, pname, volname, V_PEEK);
+    if (mode == VOL_INFO_LIST_MULTIPLE)
+       tv = VAttachVolumeByName(&error, pname, volname, V_PEEK);
+    else
+       tv = VAttachVolumeByName_retry(&error, pname, volname, V_PEEK);
     if (error) {
        Log("1 Volser: GetVolInfo: Could not attach volume %u (%s:%s) error=%d\n",
            volumeId, pname, volname, error);