uss: signed/unsigned char fallout

When char is signed, assigning 255 to a variable of type char changes
the value, which causes clang to emit a warning and fail the
--enable-checking build.

Reviewed-on: https://gerrit.openafs.org/13475
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Cheyenne Wills <cwills@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
(cherry picked from commit 7c15e6efe62fb3fe1970c56331df09b257abf6d9)

Change-Id: I3dd374582b57e46460ea80ead75913948c2d2262
Reviewed-on: https://gerrit.openafs.org/13744
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Marcio Brito Barbosa <mbarbosa@sinenomine.net>
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>

diff --git a/src/uss/uss_kauth.c b/src/uss/uss_kauth.c
index da956bd947b896c9a6ca0ae87fb4479f34f4d864..11cbe6cdb63054c904c554e0d5fb9be9a8028b33 100644 (file)
--- a/src/uss/uss_kauth.c
+++ b/src/uss/uss_kauth.c
@@ -641,7 +641,7 @@ uss_kauth_SetFields(char *username, char *expirestring, char *reuse,
        fprintf(stderr, "Zero represents unlimited login attempts.\n");
        fprintf(stderr, "Continuing with limit == 254 for user %s.\n",
                username);
-       misc_auth_bytes[2] = 255;
+       misc_auth_bytes[2] = 0xff;
     } else
        misc_auth_bytes[2] = nfailures + 1;