]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
Windows: AFSEvaluateTargetByName NULL ptr assignment
authorJeffrey Altman <jaltman@your-file-system.com>
Tue, 21 Jan 2014 09:19:28 +0000 (04:19 -0500)
committerJeffrey Altman <jaltman@your-file-system.com>
Fri, 22 Aug 2014 03:46:01 +0000 (23:46 -0400)
If DirEnumEntry is NULL, then on failure of AFSEvaluateTargetByName()
a NULL pointer will be dereferenced prior to function return.

Change-Id: I6d0d646e667c4b805abcddce1af49b81037ae51d
Reviewed-on: http://gerrit.openafs.org/11422
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
src/WINNT/afsrdr/kernel/lib/AFSCommSupport.cpp

index 858aba0c89166dbea58dcbdc8da9b90f2a0a31a4..f912cea58324e8949000b7c2bff8667d895bdcca 100644 (file)
@@ -3024,7 +3024,11 @@ try_exit:
                 AFSExFreePoolWithTag( pDirEnumCB, AFS_GENERIC_MEMORY_3_TAG);
             }
 
-            *DirEnumEntry = NULL;
+           if( DirEnumEntry != NULL)
+           {
+
+               *DirEnumEntry = NULL;
+           }
         }
     }