aklog: those pesky assignments in conditionals

This one should actually be an assignment, and the compiler warning
for having two sets of parentheses is helpful.

Found by clang on FreeBSD 10.0.

Change-Id: Ic906cbdc50a20bcd0b91555581b60c518da2bc81
Reviewed-on: http://gerrit.openafs.org/10823
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Perry Ruiter <pruiter@sinenomine.net>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: D Brashear <shadow@your-file-system.com>

diff --git a/src/aklog/aklog.c b/src/aklog/aklog.c
index 77d95483be7406cc64af5b45be9630dda2f9a06c..f397bf5ddaf86f95e3b8673f69de4c757718830a 100644 (file)
--- a/src/aklog/aklog.c
+++ b/src/aklog/aklog.c
@@ -1856,7 +1856,7 @@ get_credv5_akimpersonate(krb5_context context,
         krb5_keytab_entry new[1];
         int best = -1;
         memset(new, 0, sizeof *new);
-        if ((code == krb5_kt_start_seq_get(context, kt, cursor))) {
+        if ((code = krb5_kt_start_seq_get(context, kt, cursor))) {
             afs_com_err(progname, code, "while starting keytab scan");
             goto cleanup;
         }