rx: Don't maintain maxSerial

There were no users within the code of the rx connection maxSerial
element, and maintaining it required locking on a critical path. So,
get rid of it.

Reviewed-on: http://gerrit.openafs.org/4797
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Jeffrey Altman <jaltman@openafs.org>
Reviewed-by: Jeffrey Altman <jaltman@openafs.org>
(cherry picked from commit 6a22a2f4b7aa0d960cea17b419003986f6184d58)

Change-Id: I465e73b7cc7c57b384cd2652bbc8825a898b8bbc
Reviewed-on: http://gerrit.openafs.org/4930
Reviewed-by: Derrick Brashear <shadow@dementia.org>
Tested-by: Derrick Brashear <shadow@dementia.org>

diff --git a/src/rx/rx.c b/src/rx/rx.c
index 45f274374279e88a1ab48f64e1a6d737fb78f4b1..b71370aabe36272b7964e9686e9c92771e65fd5e 100644 (file)
--- a/src/rx/rx.c
+++ b/src/rx/rx.c
@@ -3175,11 +3175,6 @@ rxi_ReceivePacket(struct rx_packet *np, osi_socket socket,
        return np;
     }
 
-    MUTEX_ENTER(&conn->conn_data_lock);
-    if (conn->maxSerial < np->header.serial)
-       conn->maxSerial = np->header.serial;
-    MUTEX_EXIT(&conn->conn_data_lock);
-
     /* If the connection is in an error state, send an abort packet and ignore
      * the incoming packet */
     if (conn->error) {

diff --git a/src/rx/rx.h b/src/rx/rx.h
index 957ade6b67da2af7714987a19cfa22ac02a0c7a1..7f5b1403f671aadce349dd0cd62be7be5234756f 100644 (file)
--- a/src/rx/rx.h
+++ b/src/rx/rx.h
@@ -249,7 +249,6 @@ struct rx_connection {
                                        * call slot, or 0 if the slot is not busy */
     afs_uint32 serial;         /* Next outgoing packet serial number */
     afs_uint32 lastSerial;     /* # of last packet received, for computing skew */
-    afs_int32 maxSerial;       /* largest serial number seen on incoming packets */
     afs_int32 lastPacketSize; /* last >max attempt */
     afs_int32 lastPacketSizeSeq; /* seq number of attempt */
     afs_int32 lastPingSize; /* last MTU ping attempt */