]> git.michaelhowe.org Git - packages/o/openafs.git/commitdiff
budb: don't malloc(0) on error condition in GetText()
authorGarrett Wollman <wollman@csail.mit.edu>
Sun, 15 Jul 2012 18:18:12 +0000 (14:18 -0400)
committerDerrick Brashear <shadow@dementix.org>
Mon, 16 Jul 2012 12:48:00 +0000 (05:48 -0700)
malloc(0) is non-portable (may return a pointer to no space, or it
may return NULL.  Just set the result to NULL without bothering to
call malloc(), as is done earlier in this function.

Change-Id: Ic3562e722113a1409ec7c30bd571e9470b3e092b
Reviewed-on: http://gerrit.openafs.org/7766
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
src/budb/db_text.c

index 4e58195f698810fc3f3ef411348437ea48b4ecba..1d1a3b4a9d2a931894603efa1d5775a9f3337d26 100644 (file)
@@ -177,7 +177,7 @@ GetText(struct rx_call *call, afs_uint32 lockHandle, afs_int32 textType,
 
   no_xfer_abort:
     charListPtr->charListT_len = 0;
-    charListPtr->charListT_val = malloc(0);
+    charListPtr->charListT_val = NULL;
 
   abort_exit:
     if (ut)