DEVEL15-ubik-uninitialized-var-20081018

LICENSE MIT

'pass' must be initialized.  do so.

(cherry picked from commit 7e8c41d53fcd51ae0ff4420ba1027b354af306c8)

diff --git a/src/ubik/recovery.c b/src/ubik/recovery.c
index 9b76e0d3b6df3ae7a4d69e0e2c4a7e890697fd94..ae3a7ee4091a895f05fedc300f03b67f3f1cb0f7 100644 (file)
--- a/src/ubik/recovery.c
+++ b/src/ubik/recovery.c
@@ -605,6 +605,7 @@ urecovery_Interact(void *dummy)
            }
 #endif
 
+           pass = 0;
            while (length > 0) {
                tlen = (length > sizeof(tbuffer) ? sizeof(tbuffer) : length);
 #ifndef AFS_PTHREAD_ENV

diff --git a/src/ubik/remote.c b/src/ubik/remote.c
index 2ed2a29e87a1714f839eaa4201b5e7458f307e53..c30bb0cf81a956df94d529fbcfed5776aed88658 100644 (file)
--- a/src/ubik/remote.c
+++ b/src/ubik/remote.c
@@ -560,7 +560,6 @@ SDISK_SendFile(rxcall, file, length, avers)
        close(fd);
        goto failed;
     }
-#else
     pass = 0;
 #endif
     memcpy(&ubik_dbase->version, &tversion, sizeof(struct ubik_version));