From: Ben Kaduk <kaduk@mit.edu>
Date: Wed, 31 Jul 2013 00:17:01 +0000 (-0400)
Subject: Do not use a non-literal format string
X-Git-Tag: upstream/1.8.0_pre1^2~1051
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0013ca2e15b7219400b1615931492436ea987062;p=packages%2Fo%2Fopenafs.git

Do not use a non-literal format string

Now that UKERNEL's panic() is a proper varargs function (gerrit 9877),
we can use a literal format string "%s" to print the panic message.
clang warngs about a non-literal format string, and in some build
environments the warning becomes fatal via -Werror.

Change-Id: I7d8c9390e3edad7efa6ae1217f938b635423d23a
Reviewed-on: http://gerrit.openafs.org/10114
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/rx/rx_kcommon.c b/src/rx/rx_kcommon.c
index 68310a3ab..430f29c88 100644
--- a/src/rx/rx_kcommon.c
+++ b/src/rx/rx_kcommon.c
@@ -1321,7 +1321,7 @@ osi_Panic(char *msg, ...)
 # ifdef AFS_LINUX20_ENV
     * ((char *) 0) = 0;
 # else
-    panic(msg);
+    panic("%s", msg);
 # endif
 #endif
 }