From: Simon Wilkinson Date: Mon, 27 Sep 2010 22:50:23 +0000 (+0100) Subject: rx: Limit window size to max acks X-Git-Tag: openafs-devel-1_5_78~107 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0054458d07ee4304ad52d6ace68c742b1b8a68e8;p=packages%2Fo%2Fopenafs.git rx: Limit window size to max acks The RX ack packet can only acknowledge 255 packets at once. In the current implementation, this limits our maximum window size to 255, as we can't acknowledge any packets we receive outside of that window size. Reviewed-on: http://gerrit.openafs.org/2857 Reviewed-by: Jeffrey Altman Tested-by: Jeffrey Altman (cherry picked from commit 50920c0384189a6c635ca58c38bf7c942c0446b2) Change-Id: I523afdacfc2a50239219d6d39cbea58ca22fee2e Reviewed-on: http://gerrit.openafs.org/2931 Reviewed-by: Derrick Brashear Tested-by: Derrick Brashear --- diff --git a/src/rx/rx_globals.h b/src/rx/rx_globals.h index a6d02e613..a515c1178 100644 --- a/src/rx/rx_globals.h +++ b/src/rx/rx_globals.h @@ -126,7 +126,7 @@ EXT int rx_BusyError GLOBALSINIT(-1); EXT int rx_minPeerTimeout GLOBALSINIT(2); /* in milliseconds */ EXT int rx_minWindow GLOBALSINIT(1); -EXT int rx_maxWindow GLOBALSINIT(65535); /* twind is u_short */ +EXT int rx_maxWindow GLOBALSINIT(RX_MAXACKS); /* must ack what we receive */ EXT int rx_initReceiveWindow GLOBALSINIT(16); /* how much to accept */ EXT int rx_maxReceiveWindow GLOBALSINIT(32); /* how much to accept */ EXT int rx_initSendWindow GLOBALSINIT(16);