From: Simon Wilkinson <sxw@your-file-system.com>
Date: Thu, 3 Nov 2011 10:10:23 +0000 (+0000)
Subject: Unix CM: Fix dir buffer leak in afs_readdir
X-Git-Tag: upstream/1.8.0_pre1^2~3080
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=025a7aee0b86c7d8a7299c85c88615eb8cd6b07f;p=packages%2Fo%2Fopenafs.git

Unix CM: Fix dir buffer leak in afs_readdir

Resolve a buffer leak in afs_readdir that was visible on all non-Linux
platforms (Linux has an independent readdir implementation)

Change-Id: Ia5106f0e5c57430d3483b6add5b1629ff3fbc7b3
Reviewed-on: http://gerrit.openafs.org/5794
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@secure-endpoints.com>
Reviewed-by: Derrick Brashear <shadow@dementix.org>
---

diff --git a/src/afs/VNOPS/afs_vnop_readdir.c b/src/afs/VNOPS/afs_vnop_readdir.c
index f0572b958..8316bb9c4 100644
--- a/src/afs/VNOPS/afs_vnop_readdir.c
+++ b/src/afs/VNOPS/afs_vnop_readdir.c
@@ -914,6 +914,7 @@ afs_readdir(OSI_VC_DECL(avc), struct uio *auio, afs_ucred_t *acred)
 #endif /* AFS_SGI53_ENV */
 	
 	DRelease(&oldEntry, 0);
+	oldEntry = nextEntry;
 	ode = nde;
 	AFS_UIO_SETOFFSET(auio, (afs_int32) ((us + afs_dir_NameBlobs(nde->name)) << 5));
     }