From: Derrick Brashear <shadow@dementia.org>
Date: Tue, 10 Jun 2003 20:22:47 +0000 (+0000)
Subject: STABLE12-rxkad-check-tkt-length-20030610
X-Git-Tag: openafs-stable-1_2_10~40
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=04172e9a2500f5f846a7bede87e1d578232adf9e;p=packages%2Fo%2Fopenafs.git

STABLE12-rxkad-check-tkt-length-20030610


tkt_DecodeTicket didn't seem to check that ticketLen < MAXKTCTICKETLEN

didn't matter since no callers failed to check, but we should enforce this where the limit is


(cherry picked from commit 8a33c2d8a590d92df27d7febf708449feae17254)
---

diff --git a/src/rxkad/ticket.c b/src/rxkad/ticket.c
index 9b9132be0..6244c8e74 100644
--- a/src/rxkad/ticket.c
+++ b/src/rxkad/ticket.c
@@ -101,6 +101,7 @@ int tkt_DecodeTicket (asecret, ticketLen, key,
 
     if (ticketLen == 0) return RXKADBADTICKET; /* no ticket */
     if ((ticketLen < MINKTCTICKETLEN) || /* minimum legal ticket size */
+	(ticketLen > MAXKTCTICKETLEN) || /* maximum legal ticket size */
 	((ticketLen) % 8 != 0))		/* enc. part must be (0 mod 8) bytes */
 	return RXKADBADTICKET;