From: Jeffrey Altman <jaltman@secure-endpoints.com>
Date: Sat, 18 Oct 2008 16:24:57 +0000 (+0000)
Subject: STABLE14-ubik-uninitialized-var-20081018
X-Git-Tag: openafs-stable-1_4_8pre3~9
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=05473b8ccb5c3dab0d46df5922fc237254f7fc6f;p=packages%2Fo%2Fopenafs.git

STABLE14-ubik-uninitialized-var-20081018

LICENSE MIT

'pass' must be initialized.  do so.


(cherry picked from commit 7e8c41d53fcd51ae0ff4420ba1027b354af306c8)
---

diff --git a/src/ubik/recovery.c b/src/ubik/recovery.c
index 20ba9f24e..7aa4242a4 100644
--- a/src/ubik/recovery.c
+++ b/src/ubik/recovery.c
@@ -591,6 +591,7 @@ urecovery_Interact(void *dummy)
 	    }
 #endif
 
+	    pass = 0;
 	    while (length > 0) {
 		tlen = (length > sizeof(tbuffer) ? sizeof(tbuffer) : length);
 #ifndef AFS_PTHREAD_ENV
diff --git a/src/ubik/remote.c b/src/ubik/remote.c
index 7fc21ed5d..94c2a6f35 100644
--- a/src/ubik/remote.c
+++ b/src/ubik/remote.c
@@ -560,7 +560,6 @@ SDISK_SendFile(rxcall, file, length, avers)
 	close(fd);
 	goto failed;
     }
-#else
     pass = 0;
 #endif
     memcpy(&ubik_dbase->version, &tversion, sizeof(struct ubik_version));