From: Simon Wilkinson <sxw@your-file-system.com>
Date: Thu, 21 Feb 2013 21:44:43 +0000 (+0000)
Subject: bosserver: Remove dead assignment
X-Git-Tag: upstream/1.8.0_pre1^2~1447
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=054c587fcc397be6123e90115e960bd63a7c4ba0;p=packages%2Fo%2Fopenafs.git

bosserver: Remove dead assignment

In the Restart RPC handler, don't assign a value to code
immediately before we use it to hold the return value of
bozo_WaitStatus.

Caught by clang-analyzer

Change-Id: I0781c57c87088cb3ba6170ca1e5c8d5053cf9001
Reviewed-on: http://gerrit.openafs.org/9231
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/bozo/bosoprocs.c b/src/bozo/bosoprocs.c
index e90c6024f..5204002b7 100644
--- a/src/bozo/bosoprocs.c
+++ b/src/bozo/bosoprocs.c
@@ -1006,9 +1006,6 @@ SBOZO_Restart(struct rx_call *acall, char *ainstance)
 	goto fail;
     }
 
-    /* setup return code */
-    code = 0;
-
     bnode_Hold(tb);
     bnode_SetStat(tb, BSTAT_SHUTDOWN);
     code = bnode_WaitStatus(tb, BSTAT_SHUTDOWN);	/* this can fail */