From: Derrick Brashear <shadow@dementia.org>
Date: Thu, 28 Jul 2005 22:11:19 +0000 (+0000)
Subject: STABLE14-vnrehash-avoid-cachecheck-change-20050618
X-Git-Tag: openafs-devel-1_3_86~7
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0677b3c4aa7c73b654a964857c77bd4a1150a893;p=packages%2Fo%2Fopenafs.git

STABLE14-vnrehash-avoid-cachecheck-change-20050618


unlocking and locking lets us race and makes cacheCheck potentially go bad
---

diff --git a/src/vol/vnode.c b/src/vol/vnode.c
index 7f4876bbc..3e4b45df4 100644
--- a/src/vol/vnode.c
+++ b/src/vol/vnode.c
@@ -350,8 +350,10 @@ VAllocVnode_r(Error * ec, Volume * vp, VnodeType type)
 	    VOL_UNLOCK;
 	    ObtainWriteLock(&vnp->lock);
 	    VOL_LOCK;
-	    if (vnp->volumePtr->cacheCheck != vnp->cacheCheck)
+	    if (vnp->volumePtr->cacheCheck != vnp->cacheCheck) {
+		ReleaseWriteLock(&vnp->lock);
 		goto vnrehash;
+	    }
 	}
 #ifdef AFS_PTHREAD_ENV
 	vnp->writer = pthread_self();