From: Simon Wilkinson <sxw@your-file-system.com>
Date: Wed, 10 Oct 2012 13:42:21 +0000 (+0100)
Subject: tests: Tidy up loopback adapter tests
X-Git-Tag: upstream/1.8.0_pre1^2~1934
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=072828a1f5447ef64f92b2c57b8681a4e254b0f8;p=packages%2Fo%2Fopenafs.git

tests: Tidy up loopback adapter tests

Remove the unused h_errno extern, which in turn removes the need
for disabling strict prototype warnings in the Makefile

Use roken.h, instead of hardcoding system libraries

Change-Id: Ie654c77ff60ed14fc3b659fa3eb527535be71164
Reviewed-on: http://gerrit.openafs.org/8228
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/tests/common/Makefile.in b/tests/common/Makefile.in
index 2909f6134..f71d9d37f 100644
--- a/tests/common/Makefile.in
+++ b/tests/common/Makefile.in
@@ -5,7 +5,6 @@ include @TOP_OBJDIR@/src/config/Makefile.config
 include @TOP_OBJDIR@/src/config/Makefile.pthread
 
 MODULE_CFLAGS=-I$(srcdir)/.. -I$(srcdir)/../..
-CFLAGS_network.o = -Wno-strict-prototypes
 
 all check test tests:	config.o servers.o ubik.o rxkad.o network.o
 
diff --git a/tests/common/network.c b/tests/common/network.c
index e605b2853..145ce9583 100644
--- a/tests/common/network.c
+++ b/tests/common/network.c
@@ -1,18 +1,14 @@
 #include <afsconfig.h>
 #include <afs/param.h>
+
+#include <roken.h>
+
 #include <afs/cellconfig.h>
 #include <rx/rx.h>
 
-#include <stdio.h>
-#include <unistd.h>
-#include <netdb.h>
-#include <string.h>
-
 #include <tests/tap/basic.h>
 #include "common.h"
 
-extern int h_errno;
-
 /*! Check if the current machine's hostname resolves to the loopback
  * network.
  */