From: Simon Wilkinson <sxw@your-file-system.com>
Date: Fri, 30 Mar 2012 18:24:23 +0000 (+0100)
Subject: ptserver: Remove redundant braces
X-Git-Tag: upstream/1.6.8^2~80
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0bb974222e31a7e7cfea1e2c1b15f542b99dbf99;p=packages%2Fo%2Fopenafs.git

ptserver: Remove redundant braces

Doing if ((a==b)) is unecessary. It's also potentially dangerous, as
that's the syntax required to do assignment within an if statement.
clang now issues warnings (errors in -Werror mode) when it encounters
these.

Remove pointless braces from ptserver to make clang happy.

Reviewed-on: http://gerrit.openafs.org/7080
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: Derrick Brashear <shadow@dementix.org>
(cherry picked from commit 4d4e4dde7c0efcf238251b1ea1dc3933810062d0)

Change-Id: I4aad6766fc759895c8bffc16dde06169589f64ba
Reviewed-on: http://gerrit.openafs.org/10737
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
---

diff --git a/src/ptserver/pts.c b/src/ptserver/pts.c
index a0ce821e5..0035f5bac 100644
--- a/src/ptserver/pts.c
+++ b/src/ptserver/pts.c
@@ -508,7 +508,7 @@ GetNameOrId(struct cmd_syndesc *as, struct idlist *lids,
 	afs_com_err(whoami, code, "so couldn't look up names");
     else {
 	for (n = 0; n < tids.idlist_len; n++) {
-	    if ((tids.idlist_val[n] == ANONYMOUSID)) {
+	    if (tids.idlist_val[n] == ANONYMOUSID) {
 		afs_com_err(whoami, PRNOENT, "so couldn't look up id for %s",
 			names.namelist_val[n]);
 	    } else