From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 24 Feb 2013 10:36:57 +0000 (+0000)
Subject: butc: Remove dead loop pointer allocations
X-Git-Tag: upstream/1.8.0_pre1^2~1436
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0cb0d44da3d35a9d58ad9714042ea15c7b85c65a;p=packages%2Fo%2Fopenafs.git

butc: Remove dead loop pointer allocations

All of these *Ptr values are reset upon each iteration of the
while loop, so we don't need to NULL them immediately before
we go around again.

Caught by clang-analyzer

Change-Id: Iaa5ff6c7b154072e23eae272031919b424568eff
Reviewed-on: http://gerrit.openafs.org/9244
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/butc/dbentries.c b/src/butc/dbentries.c
index a3faf8cfe..3a358cef4 100644
--- a/src/butc/dbentries.c
+++ b/src/butc/dbentries.c
@@ -474,10 +474,6 @@ dbWatcher(void *unused)
 		    free(entryPtr->dlq_structPtr);
 		free(entryPtr);
 	    }
-	    entryPtr = (dlqlinkP) 0;
-	    dumpPtr = (budb_dumpEntry *) 0;
-	    volPtr = (budb_volumeEntry *) 0;
-	    tapePtr = (budb_tapeEntry *) 0;
 	}			/*while */
 
 	dbWatcherinprogress = 0;