From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 19 Feb 2013 15:27:58 +0000 (+0000)
Subject: libacl: Remove unnecessary assignment
X-Git-Tag: upstream/1.8.0_pre1^2~1502
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0ecd78058c5f78bbb88952993abd0003625b82e7;p=packages%2Fo%2Fopenafs.git

libacl: Remove unnecessary assignment

Don't assign i to j, when we never use j again in the function

Caught by clang-analyzer

Change-Id: I9dd2d929019ac3cc84cde4e44c4883806bd5964a
Reviewed-on: http://gerrit.openafs.org/9175
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/libacl/aclprocs.c b/src/libacl/aclprocs.c
index fd4d8777f..8643cae6b 100644
--- a/src/libacl/aclprocs.c
+++ b/src/libacl/aclprocs.c
@@ -305,7 +305,6 @@ acl_Internalize_pr(int (*func)(namelist *names, idlist *ids), char *elist, struc
 	}
 	(*acl)->entries[i].id = lids.idlist_val[i];
     }
-    j = i;
     for (i = (*acl)->total - 1; i >= (*acl)->total - (*acl)->negative; i--) {
 	if (lids.idlist_val[i] == ANONYMOUSID) {
 	    free(lnames.namelist_val);