From: Derrick Brashear <shadow@dementia.org>
Date: Tue, 8 Sep 2009 02:29:54 +0000 (-0400)
Subject: fetchstore nocall argument breaks non-64bit clients
X-Git-Tag: openafs-devel-1_5_63~40
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=0ee69d5b9a64a96c5c217d523ba23371d41cb85d;p=packages%2Fo%2Fopenafs.git

fetchstore nocall argument breaks non-64bit clients

a label before the end of a loop breaks, which is the case
when AFS_64BIT_CLIENT's not defined (e.g. UKERNEL).

fix it.

Reviewed-on: http://gerrit.openafs.org/410
Tested-by: Derrick Brashear <shadow@dementia.org>
Reviewed-by: Derrick Brashear <shadow@dementia.org>
---

diff --git a/src/afs/afs_fetchstore.c b/src/afs/afs_fetchstore.c
index 6ab62557e..86f590676 100644
--- a/src/afs/afs_fetchstore.c
+++ b/src/afs/afs_fetchstore.c
@@ -612,12 +612,11 @@ afs_CacheStoreVCache(struct dcache **dcList, struct vcache *avc,
 #endif
 		code = rxfs_storeInit(avc, tc, length, bytes, base,
 					sync, &ops, &rock);
-		if ( code )
-		    goto nocall;
 
-		code = afs_CacheStoreDCaches(avc, dclist, bytes, anewDV,
-			&doProcessFS, &OutStatus, nchunks, nomore, ops, rock);
-nocall:
+		if (!code) 
+		    code = afs_CacheStoreDCaches(avc, dclist, bytes, anewDV,
+						 &doProcessFS, &OutStatus, 
+						 nchunks, nomore, ops, rock);
 #ifdef AFS_64BIT_CLIENT
 		if (code == RXGEN_OPCODE && !afs_serverHasNo64Bit(tc)) {
 		    afs_serverSetNo64Bit(tc);