From: Jeffrey Altman <jaltman@your-file-system.com>
Date: Tue, 19 Jun 2012 01:49:18 +0000 (-0400)
Subject: Windows: NPLogonNotify secure erase password
X-Git-Tag: upstream/1.8.0_pre1^2~2284
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=187af8d11350c2ff509244f216c72bdd4b88451a;p=packages%2Fo%2Fopenafs.git

Windows: NPLogonNotify secure erase password

The user's password is copied during the NPLogonNotify
processing, be sure to erase it from the stack before the
function completes.

Change-Id: Ib600f5656f7b32628e7105336ff0ffef8f15272f
Reviewed-on: http://gerrit.openafs.org/7632
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: Jeffrey Altman <jaltman@your-file-system.com>
---

diff --git a/src/WINNT/afsd/afslogon.c b/src/WINNT/afsd/afslogon.c
index ab7cbfbe9..0138c62ce 100644
--- a/src/WINNT/afsd/afslogon.c
+++ b/src/WINNT/afsd/afslogon.c
@@ -1205,6 +1205,8 @@ NPLogonNotify(
     if (opt.smbName) free(opt.smbName);
     if (opt.realm) free(opt.realm);
 
+    SecureZeroMemory(password, sizeof(password));
+
     DebugEvent("AFS AfsLogon - Exit","Return Code[%x]",code);
     return code;
 }