From: Simon Wilkinson <sxw@your-file-system.com>
Date: Sun, 9 Oct 2011 00:17:19 +0000 (+0100)
Subject: cmd: Don't expose krb5 error codes
X-Git-Tag: upstream/1.8.0_pre1^2~2420
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=1a823e9326ca7210a7381b9691227e1b4c8f89a8;p=packages%2Fo%2Fopenafs.git

cmd: Don't expose krb5 error codes

Don't use krb5 error codes in our configuration parser, instead use an
error allocated from the existing cmd error table

Change-Id: I777d9638c676d198d13a3bd33a90acdc53dc26cc
Reviewed-on: http://gerrit.openafs.org/7134
Reviewed-by: Derrick Brashear <shadow@dementix.org>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/cmd/cmd_errors.et b/src/cmd/cmd_errors.et
index fd8453b92..dbc75e403 100644
--- a/src/cmd/cmd_errors.et
+++ b/src/cmd/cmd_errors.et
@@ -19,4 +19,5 @@ error_table CMD
   ec CMD_TOOFEW, "Insufficient required parameters provided"
   ec CMD_TOOBIG, "Token too large"
   ec CMD_MISSING, "Option not specified on command line"
+  ec CMD_BADFORMAT, "Improper format of configuration file"
 end
diff --git a/src/cmd/krb5_locl.h b/src/cmd/krb5_locl.h
index 9b5b095bb..bbb179813 100644
--- a/src/cmd/krb5_locl.h
+++ b/src/cmd/krb5_locl.h
@@ -37,8 +37,7 @@
 
 #define KRB5_DEPRECATED_FUNCTION(x)
 
-/* This value shouldn't be hard coded */
-#define KRB5_CONFIG_BADFORMAT                    (-1765328248L)
+#define KRB5_CONFIG_BADFORMAT                    CMD_BADFORMAT
 
 #define N_(X,Y) X