From: Simon Wilkinson <sxw@your-file-system.com>
Date: Mon, 4 Mar 2013 16:34:20 +0000 (+0000)
Subject: butc: Init volheader before using it for hton
X-Git-Tag: upstream/1.8.0_pre1^2~1308
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=21166744bf15f13bc04c25d68a28fe803a960b0a;p=packages%2Fo%2Fopenafs.git

butc: Init volheader before using it for hton

When converting a volume header from host to network order, make
sure that any unused fields in the structure are zero'd, so we don't
end up filling them with stack garbage in the network version of
the structure.

Caught by coverity (#985956)

Change-Id: I3e039ffcb102a97afeb0e2223de12523f53b0a67
Reviewed-on: http://gerrit.openafs.org/9548
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
Reviewed-by: Jeffrey Altman <jaltman@your-file-system.com>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/butc/dump.c b/src/butc/dump.c
index c0d96957b..7c836a654 100644
--- a/src/butc/dump.c
+++ b/src/butc/dump.c
@@ -1859,6 +1859,8 @@ volumeHeader_hton(struct volumeHeader *hostPtr, struct volumeHeader *netPtr)
 {
     struct volumeHeader volHdr;
 
+    memset(&volHdr, 0, sizeof(volHdr));
+
     strcpy(volHdr.preamble, hostPtr->preamble);
     strcpy(volHdr.postamble, hostPtr->postamble);
     strcpy(volHdr.volumeName, hostPtr->volumeName);