From: Simon Wilkinson <sxw@your-file-system.com>
Date: Tue, 26 Feb 2013 11:52:01 +0000 (+0000)
Subject: libafscp: NULL return value not pointer
X-Git-Tag: upstream/1.6.6_pre2^2~131
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=220336585530ff9f0b4b1e3b47e3dd6727a18ab3;p=packages%2Fo%2Fopenafs.git

libafscp: NULL return value not pointer

When afscp_FindCallBack sets its return-by-reference value to NULL,
it should do so to the value itself, not the pointer to it.

Caught by coverity (#988419)

Reviewed-on: http://gerrit.openafs.org/9266
Tested-by: BuildBot <buildbot@rampaginggeek.com>
Reviewed-by: Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
(cherry picked from commit 99929488511d13dab94491cac1d477062f9da741)

Change-Id: I046189684cef6c88c46455a90ab49d03da1f1cab
Reviewed-on: http://gerrit.openafs.org/9359
Tested-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Stephan Wiesand <stephan.wiesand@desy.de>
Reviewed-by: Andrew Deason <adeason@sinenomine.net>
Reviewed-by: Derrick Brashear <shadow@your-file-system.com>
---

diff --git a/src/libafscp/afscp_callback.c b/src/libafscp/afscp_callback.c
index e1f13d794..3bb806282 100644
--- a/src/libafscp/afscp_callback.c
+++ b/src/libafscp/afscp_callback.c
@@ -112,7 +112,7 @@ afscp_FindCallBack(const struct afscp_venusfid *f,
     time_t now;
     struct afscp_venusfid fid;
 
-    ret = NULL;
+    *ret = NULL;
 
     time(&now);
     for (i = 0; i < afscp_maxcallbacks; i++) {