From: Simon Wilkinson Date: Sat, 25 Jun 2011 17:29:27 +0000 (+0100) Subject: rx: Remove unused ACKHACK macro X-Git-Tag: upstream/1.8.0_pre1^2~2582 X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=2427cb000cb70cfca5b2a61d4f5f9ca54488fc55;p=packages%2Fo%2Fopenafs.git rx: Remove unused ACKHACK macro rx_globals.h had a macro called ACKHACK which at one point looks like it was used to determine whether to send an ACK or not. We now have a more sophisticate mechanism for determining this, and the old macro doesn't seem to have been used in a long time. So, remove it to avoid confusion. Change-Id: I9b17cdca69c903c7a952489791088f2899ac7e60 Reviewed-on: http://gerrit.openafs.org/7000 Reviewed-by: Derrick Brashear Tested-by: BuildBot Reviewed-by: Jeffrey Altman --- diff --git a/src/rx/rx_globals.h b/src/rx/rx_globals.h index f8c01434e..2051a26dc 100644 --- a/src/rx/rx_globals.h +++ b/src/rx/rx_globals.h @@ -134,22 +134,13 @@ EXT int rxi_OrphanFragSize GLOBALSINIT(512); #define RX_MAX_DGRAM_PACKETS 6 /* max packets per jumbogram */ EXT int rxi_nDgramPackets GLOBALSINIT(RX_MAX_DGRAM_PACKETS); -/* allow n packets between soft acks - must be power of 2 -1, else change - * macro below */ +/* allow n packets between soft acks */ EXT int rxi_SoftAckRate GLOBALSINIT(RX_FAST_ACK_RATE); /* consume n packets before sending hard ack, should be larger than above, but not absolutely necessary. If it's smaller, than fast receivers will send a soft ack, immediately followed by a hard ack. */ EXT int rxi_HardAckRate GLOBALSINIT(RX_FAST_ACK_RATE + 1); -/* If window sizes become very variable (in terms of #packets), be - * sure that the sender can get back a hard acks without having to wait for - * some kind of timer event first (like a keep-alive, for instance). - * It might be kind of tricky, so it might be better to shrink the - * window size by reducing the packet size below the "natural" MTU. */ - -#define ACKHACK(p,r) { if (((p)->header.seq & (rxi_SoftAckRate))==0) (p)->header.flags |= RX_REQUEST_ACK; } - EXT int rx_nPackets GLOBALSINIT(0); /* preallocate packets with rx_extraPackets */ /*