From: Chas Williams <3chas3@gmail.com>
Date: Mon, 23 Nov 2015 19:19:38 +0000 (-0500)
Subject: Remove automated casting in rxgen
X-Git-Tag: upstream/1.8.0_pre1^2~145
X-Git-Url: https://git.michaelhowe.org/gitweb/?a=commitdiff_plain;h=279f9c54b4ccd8a55812ac8423a153d5c2deb0ab;p=packages%2Fo%2Fopenafs.git

Remove automated casting in rxgen

We should let the compiler warn us when we attempt to convert types that
should not be converted.

Change-Id: Ie9f5f6ab5d5978bbe5e741b1a20bfb4d36fb314c
Reviewed-on: https://gerrit.openafs.org/12116
Reviewed-by: Michael Meffie <mmeffie@sinenomine.net>
Reviewed-by: Benjamin Kaduk <kaduk@mit.edu>
Tested-by: BuildBot <buildbot@rampaginggeek.com>
---

diff --git a/src/rxgen/rpc_cout.c b/src/rxgen/rpc_cout.c
index a15b627ba..3ddb27aca 100644
--- a/src/rxgen/rpc_cout.c
+++ b/src/rxgen/rpc_cout.c
@@ -221,15 +221,15 @@ print_ifarg_len(char *objname, char *name)
 {
     if (*objname == '&') {
 	if (brief_flag) {
-	    f_print(fout, "(u_int *)%s.len", objname);
+	    f_print(fout, "%s.len", objname);
 	} else {
-	    f_print(fout, "(u_int *)%s.%s_len", objname, name);
+	    f_print(fout, "%s.%s_len", objname, name);
 	}
     } else {
 	if (brief_flag) {
-	    f_print(fout, "(u_int *)&%s->len", objname);
+	    f_print(fout, "&%s->len", objname);
 	} else {
-	    f_print(fout, "(u_int *)&%s->%s_len", objname, name);
+	    f_print(fout, "&%s->%s_len", objname, name);
 	}
     }
 }